Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: EFLFE.PingoMeter version 0.9.9 #178129

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

grigoryvp
Copy link
Contributor

@grigoryvp grigoryvp commented Oct 5, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Oct 5, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Executable C:\Users\Validator\AppData\Local\Microsoft\WinGet\Links\pingometer.exe returned exit code: -1073741819
Executable C:\Users\Validator\AppData\Local\Microsoft\WinGet\Links\pingometer.exe returned exit code: -532462766

Automated error analysis suggests -1073741819 may mean Converted to hexadecimal (C0000005) possibly Access Violation. (This is occasionally seen in PRs despite the install otherwise being successful. Should it be added as an InstallerSuccessCode or similar here?)

Automated error analysis suggests -532462766 may mean EXCEPTION_COMPLUS (Unhandled Exception)

(Automated response - build 896.)

@stephengillie
Copy link
Collaborator

Verify:
image
The symlink can't reach files needed by the application. Here, it's none.png. Running from the main folder gives:
image
image

@stephengillie stephengillie added the zip-binary Depends on library files that aren't available via symlink label Oct 8, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Blocking-Issue Manifest validation is blocked by a known issue. Needs-Author-Feedback This needs a response from the author. Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Oct 8, 2024
@stephengillie stephengillie removed the Validation-Completed Validation passed label Oct 15, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Blocking-Issue Manifest validation is blocked by a known issue. Needs-Attention This work item needs to be reviewed by a member of the core team. New-Package labels Nov 5, 2024
auto-merge was automatically disabled November 5, 2024 19:54

Head branch was pushed to by a user without write access

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@grigoryvp
Copy link
Contributor Author

I have used the new ArchiveBinariesDependOnPath WinGet 1.9 flag to add app's directory to the PATH. This should do the trick!

@wingetbot wingetbot added the Manifest-Version-Error Unsupported manifest version label Nov 5, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback This needs a response from the author. No-Recent-Activity No activity has occurred on this work item for seven days. labels Nov 5, 2024
@grigoryvp
Copy link
Contributor Author

Updated and ready for review, I do not understand why Microsoft bot decides that there is "no activity"

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed No-Recent-Activity No activity has occurred on this work item for seven days. Needs-Author-Feedback This needs a response from the author. labels Nov 11, 2024
@ItzLevvie
Copy link
Contributor

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Version-Error Unsupported manifest version Needs-Attention This work item needs to be reviewed by a member of the core team. labels Nov 15, 2024
@wingetbot wingetbot added the Manifest-Version-Error Unsupported manifest version label Nov 15, 2024
Copy link
Contributor

Hello @grigoryvp,

The package manager bot determined that the ManifestVersion key does not match any version currently approved for release. Please verify the manifest file is compliant with the package manager 1.5 manifest specification or 1.6 manifest specification.

For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/version/error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Manifest-Version-Error Unsupported manifest version Needs-Author-Feedback This needs a response from the author. zip-binary Depends on library files that aren't available via symlink
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants