-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recommendation for users to move away from WinDirStat #174213
Add recommendation for users to move away from WinDirStat #174213
Conversation
/AzurePipelines run |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Url validation error
|
/AzurePipelines run |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
b61ea5b
into
microsoft:master
Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present. |
While WizTree may be faster, and more actively developed, it isn't open source (like WinDirStat is). Users like myself may prefer WinDirStat for this reason alone (even if it is slower). |
That is true, which is why I just added it as a note so that users can make their own decisions about the software they choose to install |
They've been making alpha/beta releases periodically this year (https://github.com/windirstat/windirstat-next/releases ). Likewise for commits (https://github.com/windirstat/windirstat/commits/master/ ), including one yesterday.
Presumably they'll have that fixed when they finally make their next major stable release: windirstat/windirstat#46 |
Perfect; Once a new version is released I'll update the manifest and remove this note, especially since there isn't a set date for the 2.0.0 version as far as I can tell |
@Trenly The next two months is my goal. Would you like me to take over updating this when the release is ready? I would appreciate you removing the note now since it is false. |
@NoMoreFood: Couldn't you do a quick release of WinDirStat, that is exactly like the current version provided in winget except that it merely sets that version registry entry that winget needs to remain aware of the installed version of WinDirstat? Perhaps that alone is more work than it might appear to me, and it is just better to wait. As for WinDirStat and "active development", I've used it for years and it doesn't bother me much that it hasn't changed since 2016. When something works well for its purpose it doesn't require too much active development. Plus, it is open source, and I typically favor that over closed source alternatives (that's more of a priority to me than performance in this case). While I'm glad to be informed of the existence WizTree, I don't like a package manager recommending a proprietary application as an alternative to an open source one unless this difference is explicitly made clear. I guess that's just my preference, but now that the note has been discovered untrue, that's probably a more agreeable reason to go ahead and remove it. |
FYI, @Trenly updated the accuracy of this note last week (the day after this PR): As I understand it, this note aimed to minimize user confusion and reduce the amount of issues being opened in this microsoft/winget-pkgs repository. While I agree that this note may have seemed biased, the updated note appears to be a reasonable compromise until 2.0.0 lands. Note as of
|
Checklist for Pull Requests
Manifests
winget validate --manifest <path>
?winget install --manifest <path>
?Note:
<path>
is the directory's name containing the manifest you're submitting.There have now been a few issues filed indicating confusion around the behavior of WinDirStat and the version being unknown.
Because the last release of WinDirStat was in 2016, it should be safe to assume that it is not in active development and no new updates for the package will be coming. However, another package - WizTree - provides the same functionality as WinDirStat but is newer, much faster, and is still being patched and developed upon.
This PR adds an installation note to help reduce confusion and point users towards the newer software if they should choose to install it.
Related to microsoft/winget-cli#1899