Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MySQL Workbench Community #12351

Closed
wants to merge 2 commits into from
Closed

Add MySQL Workbench Community #12351

wants to merge 2 commits into from

Conversation

Loupeznik
Copy link
Contributor

@Loupeznik Loupeznik commented May 9, 2021 •
edited by ghost
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label May 9, 2021
@ghost
Copy link

ghost commented May 9, 2021

@Loupeznik The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

@ghost ghost assigned arjun-msft May 9, 2021
@ghost ghost added Needs: Attention and removed Needs: author feedback Validation-Installation-Error Error installing application labels May 11, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Installation-Error Error installing application label May 11, 2021
@ghost
Copy link

ghost commented May 11, 2021

@Loupeznik The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

@Loupeznik
Copy link
Contributor Author

The installation failure seems like a dependency problem, should I close this? @arjun-msft

@denelon denelon added Blocking-Issue Manifest validation is blocked by a known issue. Dependencies and removed Needs: Attention labels May 11, 2021
@denelon
Copy link
Contributor

denelon commented May 11, 2021

@Loupeznik I added the "Blocking-Issue" and "Dependency" labels to this PR, so the work to generate the manifest doesn't have to be completely redone.

@arjun-msft arjun-msft removed their assignment May 21, 2021
@denelon
Copy link
Contributor

denelon commented Jan 29, 2022

@Loupeznik I'm working on the specification for dependencies. Do you know what dependencies are for this package?

@Loupeznik
Copy link
Contributor Author

@denelon Hi, the package seems to depend on .NET Framework 4.5.2 and Microsoft Visual C++ 2015-2022 Redistributable as per the provided documentation.

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Mar 13, 2022
@licon4812
Copy link
Contributor

@denelon @ItzLevvie
Is this request still active or am I free to have a crack at getting MySQL workbench added?

@ItzLevvie
Copy link
Contributor

ItzLevvie commented Jun 16, 2022 •
edited
Loading

I think it still requires dependency support which will take a while for it to go out of experimental features and then be added to the pipelines.

@entreprenr
Copy link

https://cdn.mysql.com//Downloads/MySQLGUITools/mysql-workbench-community-8.0.31-winx64.msi

Does this installer require any dependencies? It seems to install without asking anything (but maybe the dependency is already installed on my machine) ...

@stephengillie
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Installation-Error Error installing application Blocking-Issue Manifest validation is blocked by a known issue. labels Dec 15, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Dec 15, 2023
@stephengillie
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Dec 15, 2023
@Trenly
Copy link
Contributor

Trenly commented Dec 18, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItzLevvie ItzLevvie ItzLevvie approved these changes

Assignees

@Loupeznik Loupeznik

Labels
Dependencies Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Missing-Dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Loupeznik @wingetbot @denelon @licon4812 @ItzLevvie @entreprenr @stephengillie @Trenly @arjun-msft