Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version: Rye.Rye version 0.15.2 #122107

Merged
merged 1 commit into from
Oct 18, 2023
Merged

New version: Rye.Rye version 0.15.2 #122107

merged 1 commit into from
Oct 18, 2023

Conversation

zengqiu
Copy link
Contributor

@zengqiu zengqiu commented Oct 7, 2023 •
edited by microsoft-github-policy-service bot
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Oct 7, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Oct 7, 2023
@zengqiu
Copy link
Contributor Author

zengqiu commented Oct 8, 2023

I have successfully tested the installation, why did Installer Validation fail?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Oct 8, 2023
@Trenly
Copy link
Contributor

Trenly commented Oct 9, 2023

Dependency validation is not yet available in the pipelines.

image

@microsoft-github-policy-service microsoft-github-policy-service bot added Dependencies Blocking-Issue Manifest validation is blocked by a known issue. Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Oct 9, 2023
@zengqiu
Copy link
Contributor Author

zengqiu commented Oct 9, 2023

Dependency validation is not yet available in the pipelines.

image

The dependencies is in the install file, and when I test it will automatically install dependencies.
Why does it not automatically install dependencies when running Installer Validation?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Oct 9, 2023
@stephengillie stephengillie removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Oct 10, 2023
@zengqiu
Copy link
Contributor Author

zengqiu commented Oct 10, 2023

@stephengillie I received your comment, but the dependencies is already existed.
1
2

@stephengillie
Copy link
Collaborator

stephengillie commented Oct 10, 2023 •
edited
Loading

stephengillie I received your comment, but the dependencies is already existed.
[1]
[2]

Sorry, I saw those after suggesting.

@denelon
Copy link
Contributor

denelon commented Oct 10, 2023

Until we get automated validation, we will have to manually verify things with dependencies. I'm fine if @stephengillie has time to manually validate/approve.

We're working on the back-end validation to support validating with dependencies :)

@stephengillie
Copy link
Collaborator

x86 Manual Validation ended with:

12:14:22 PM: 2023-10-10 12:14:22.117 [FAIL] Installer failed security check. Url: https://github.com/mitsuhiko/rye/releases/download/0.15.2/rye-x86-windows.exe Result: 0x80004005

This is similar to a Defender failure. It might be a false positive and we can retry tomorrow.

@stephengillie stephengillie added Needs-Review This work item needs to be reviewed by a member of another team. Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Review This work item needs to be reviewed by a member of another team. labels Oct 10, 2023
@zengqiu
Copy link
Contributor Author

zengqiu commented Oct 17, 2023

@stephengillie Please check again. astral-sh/rye#468

@stephengillie
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Blocking-Issue Manifest validation is blocked by a known issue. Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. labels Oct 17, 2023
@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Oct 17, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Oct 17, 2023
@stephengillie
Copy link
Collaborator

@wingetbot waivers Add Validation-Unattended-Failed

@wingetbot wingetbot added the Waived-Validation-Unattended-Failed We've waived "Validation-Unsattended-Failed" it was likely a false detection. label Oct 18, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. Needs-Author-Feedback This needs a response from the author. labels Oct 18, 2023
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Oct 18, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Oct 18, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit dc06a09 into microsoft:master Oct 18, 2023
7 checks passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@zengqiu zengqiu mentioned this pull request Feb 5, 2024
Merged
6 tasks
@zengqiu zengqiu mentioned this pull request Mar 12, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie approved these changes

@microsoft-github-policy-service microsoft-github-policy-service[bot] microsoft-github-policy-service[bot] approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Dependencies Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed Waived-Validation-Unattended-Failed We've waived "Validation-Unsattended-Failed" it was likely a false detection.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zengqiu @wingetbot @Trenly @stephengillie @denelon @JohnMcPMS @hackean-msft