Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cristiano100.roforge version 0.1 #120423

Conversation

Cristiano100
Copy link
Contributor

@Cristiano100 Cristiano100 commented Sep 21, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Sep 22, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @Cristiano100,

During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI, or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect them and the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

Template: msftbot/validationError/installation/unattended

@Cristiano100
Copy link
Contributor Author

@stephengillie

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Sep 22, 2023
@stephengillie
Copy link
Collaborator

stephengillie commented Sep 22, 2023

Automatic Validation ended with:
image

Unfortunately, the issue persists.

@stephengillie stephengillie added Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Sep 22, 2023
@Trenly
Copy link
Contributor

Trenly commented Sep 25, 2023

The issue is resolved when using the PreRelease client which has dependencies as stable
[Policy] Dependencies

@microsoft-github-policy-service
Copy link
Contributor

Hello @Cristiano100,

This package appears to require dependencies in order to install successfully.

This PR is blocked until support for dependencies is implemented in:

Be sure to add your 👍 to the issue to help raise the priority and avoid posting "Me too!" messages to respect those who have subscribed to the issue.

Template: msftbot/blockingIssue/dependencySupport

@microsoft-github-policy-service microsoft-github-policy-service bot added the Blocking-Issue Manifest validation is blocked by a known issue. label Sep 25, 2023
@@ -3,7 +3,20 @@

PackageIdentifier: cristiano100.roforge
PackageVersion: "0.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The installer writes 1.0.0 to the registry. The Package Version needs to be updated to match, or AppsAndFeaturesEntries need to be added to the manifest.

--> Comparing ARP Entries

DisplayName                                      DisplayVersion Publisher             ProductCode                            Scope
-----------                                      -------------- ---------             -----------                            -----
Microsoft Edge Update                            1.3.147.37                           Microsoft Edge Update                  Machine
Microsoft Edge Update                            1.3.171.39                           Microsoft Edge Update                  Machine
Microsoft Edge WebView2 Runtime                  117.0.2045.41  Microsoft Corporation Microsoft EdgeWebView                  Machine
Microsoft Windows Desktop Runtime - 6.0.22 (x64) 6.0.22.32825   Microsoft Corporation {0f94f805-22c3-4413-b1e5-5ab275ba92d5} Machine
Roforge                                          1.0.0          Cristiano100          Roforge                                User

@microsoft-github-policy-service
Copy link
Contributor

Hello @Cristiano100,

The package manager bot determined changes have been requested to your PR.

Template: msftbot/changesRequested

@Trenly
Copy link
Contributor

Trenly commented Jan 2, 2024

Dependencies are now supported in the 1.6 client. If you could please submit a new manifest for the latest version of the package, it would be greatly appreciated!

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Blocking-Issue Manifest validation is blocked by a known issue. label Jan 2, 2024
@stephengillie
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. Needs-Author-Feedback This needs a response from the author. labels Jan 4, 2024
@wingetbot wingetbot added the Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash label Jan 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 4, 2024
@stephengillie
Copy link
Collaborator

stephengillie commented Jan 5, 2024

Automatic Validation ended with:

1/4/2024 9:36:05 PM
Installer Verification Analysis Context Information:
Specified hash doesn't match.
Actual hash: 52078C951B5995B1020B63DD7C0BDCB33037FE2E9102D1675A80ADECC85651CD
Expected hash: 032e3293563edcba08bf52b887b2e34f2e9df00ff310fa8046ae44bbe6a1b014

(Automated response - build 518.)

@stephengillie
Copy link
Collaborator

stephengillie commented Jan 5, 2024

Hi @Cristiano100,

The package hash has apparently changed to 52078C951B5995B1020B63DD7C0BDCB33037FE2E9102D1675A80ADECC85651CD. Unfortunately, GitHub doesn't easily allow me to suggest this hash in this scenario. Feel free to commit and push this new hash.

@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity No activity has occurred on this work item for seven days. label Jan 10, 2024
Copy link
Contributor

Hello @Cristiano100,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any recent activity. It will be closed if no further activity occurs within 3 days of this comment.

Template: msftbot/noRecentActivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Error-Hash-Mismatch The InstallerSHA256 Hash specified in the manifest doesn't match with the InstallerURL hash Needs-Author-Feedback This needs a response from the author. No-Recent-Activity No activity has occurred on this work item for seven days.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants