-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cristiano100.roforge version 0.1 #120423
cristiano100.roforge version 0.1 #120423
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hello @Cristiano100, During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches? This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest. Please investigate a fix and resubmit the Pull Request. You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI, or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect them and the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress. Template: msftbot/validationError/installation/unattended |
The issue is resolved when using the PreRelease client which has dependencies as stable |
Hello @Cristiano100, This package appears to require dependencies in order to install successfully. This PR is blocked until support for dependencies is implemented in: Be sure to add your 👍 to the issue to help raise the priority and avoid posting "Me too!" messages to respect those who have subscribed to the issue. Template: msftbot/blockingIssue/dependencySupport |
@@ -3,7 +3,20 @@ | |||
|
|||
PackageIdentifier: cristiano100.roforge | |||
PackageVersion: "0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The installer writes 1.0.0
to the registry. The Package Version needs to be updated to match, or AppsAndFeaturesEntries
need to be added to the manifest.
--> Comparing ARP Entries
DisplayName DisplayVersion Publisher ProductCode Scope
----------- -------------- --------- ----------- -----
Microsoft Edge Update 1.3.147.37 Microsoft Edge Update Machine
Microsoft Edge Update 1.3.171.39 Microsoft Edge Update Machine
Microsoft Edge WebView2 Runtime 117.0.2045.41 Microsoft Corporation Microsoft EdgeWebView Machine
Microsoft Windows Desktop Runtime - 6.0.22 (x64) 6.0.22.32825 Microsoft Corporation {0f94f805-22c3-4413-b1e5-5ab275ba92d5} Machine
Roforge 1.0.0 Cristiano100 Roforge User
Hello @Cristiano100, The package manager bot determined changes have been requested to your PR. Template: msftbot/changesRequested |
Dependencies are now supported in the 1.6 client. If you could please submit a new manifest for the latest version of the package, it would be greatly appreciated! |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Automatic Validation ended with:
(Automated response - build 518.) |
Hi @Cristiano100, The package hash has apparently changed to |
Hello @Cristiano100, This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any recent activity. It will be closed if no further activity occurs within 3 days of this comment. Template: msftbot/noRecentActivity |
winget validate --manifest <path>
?winget install --manifest <path>
?Note:
<path>
is the name of the directory containing the manifest you're submitting.Microsoft Reviewers: Open in CodeFlow