Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: cristiano100.roforge version 0.1 #120242

Conversation

Cristiano100
Copy link
Contributor

@Cristiano100 Cristiano100 commented Sep 20, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Cristiano100
Copy link
Contributor Author

@microsoft-github-policy-service agree

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Sep 20, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @Cristiano100,

During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI, or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect them and the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

Template: msftbot/validationError/installation/unattended

@Cristiano100
Copy link
Contributor Author

@wingetbot waivers Add Validation-Unattended-Failed

@wingetbot
Copy link
Collaborator

Commenter does not have sufficient privileges for PR 120242

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Sep 20, 2023
@Cristiano100
Copy link
Contributor Author

@stephengillie

@stephengillie
Copy link
Collaborator

Automatic Validation ended with:
image

It appears that the installer is behind the WinGet window. I'll manually validate.

@stephengillie
Copy link
Collaborator

Manual Validation ended with:
image

Microsoft.DotNet.DesktopRuntime.6 appears to be a dependency.

@stephengillie stephengillie added Dependencies and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Sep 20, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @Cristiano100,

This package appears to require dependencies in order to install successfully.

This PR is blocked until support for dependencies is implemented in:

Be sure to add your 👍 to the issue to help raise the priority and avoid posting "Me too!" messages to respect those who have subscribed to the issue.

Template: msftbot/blockingIssue/dependencySupport

@microsoft-github-policy-service microsoft-github-policy-service bot added Blocking-Issue Manifest validation is blocked by a known issue. Needs-Author-Feedback This needs a response from the author. labels Sep 20, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Blocking-Issue Manifest validation is blocked by a known issue. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. Needs-Author-Feedback This needs a response from the author. labels Sep 20, 2023
@Cristiano100
Copy link
Contributor Author

@stephengillie

1 similar comment
@Cristiano100
Copy link
Contributor Author

@stephengillie

@stephengillie
Copy link
Collaborator

@stephengillie

Hi @Cristiano100,

This is expected - whenever the PR gets updated, our automation removes validation labels and runs the PR through the validation process again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants