Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: SolveSpace.SolveSpace version 3.1 #118952

Conversation

ruevs
Copy link
Contributor

@ruevs ruevs commented Sep 5, 2023

Pull request has been created with Komac v1.11.0 🚀

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Sep 5, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @ruevs,

Please verify the manifest file is compliant with the package manager 1.0 manifest specification, 1.1 manifest specification, 1.2 manifest specification, or 1.4 manifest specification.

Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.

Note: The path and "PackageIdentifier" are case sensitive.

Be sure to use a tool like VSCode to make sure the manifest YAML syntax is correct. You can also validate your manifest using the winget validate command.

For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/content

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Sep 5, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. labels Sep 5, 2023
@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Sep 5, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @ruevs,

Please verify the manifest file is compliant with the package manager 1.0 manifest specification, 1.1 manifest specification, 1.2 manifest specification, or 1.4 manifest specification.

Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.

Note: The path and "PackageIdentifier" are case sensitive.

Be sure to use a tool like VSCode to make sure the manifest YAML syntax is correct. You can also validate your manifest using the winget validate command.

For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/content

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Sep 5, 2023
@ruevs
Copy link
Contributor Author

ruevs commented Sep 5, 2023

@microsoft-github-policy-service agree

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Sep 5, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Manifest-Validation-Error Manifest validation failed label Sep 5, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@stephengillie
Copy link
Collaborator

@wingetbot waivers Add Validation-Executable-Error Validation-Missing-Dependency

@wingetbot
Copy link
Collaborator

Invalid arguments for command waivers with action add Received 'Add Validation-Executable-Error Validation-Missing-Dependency'

wingetbot command waivers supported actions

  • add:
    • Add a temporary waiver for the specified labels.
    • Example: @wingetbot waivers add Policy-Test-2.7 Validation-Domain
  • remove:
    • Removes a temporary waiver for the specified labels.
    • Example: @wingetbot waivers remove Policy-Test-2.7 Validation-Domain
  • help:
    • Displays this help.
    • Example: @wingetbot waivers help

@stephengillie
Copy link
Collaborator

This package installs and launches normally in a Windows 10 VM.

@stephengillie
Copy link
Collaborator

@wingetbot waivers Add Validation-Executable-Error

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@stephengillie
Copy link
Collaborator

@wingetbot waivers Add Validation-Missing-Dependency

@wingetbot
Copy link
Collaborator

Invalid arguments for command waivers with action add Received 'Add Validation-Missing-Dependency'

wingetbot command waivers supported actions

  • add:
    • Add a temporary waiver for the specified labels.
    • Example: @wingetbot waivers add Policy-Test-2.7 Validation-Domain
  • remove:
    • Removes a temporary waiver for the specified labels.
    • Example: @wingetbot waivers remove Policy-Test-2.7 Validation-Domain
  • help:
    • Displays this help.
    • Example: @wingetbot waivers help

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Sep 13, 2023
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Sep 13, 2023
@microsoft-github-policy-service
Copy link
Contributor

ruevs,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@ruevs
Copy link
Contributor Author

ruevs commented Sep 16, 2023

@stephengillie Is there anything else I should do for this pull request, apart from waiting for a review?

@ruevs
Copy link
Contributor Author

ruevs commented Oct 2, 2023

@stephengillie what should I do to help merge this pull request?

@stephengillie stephengillie self-assigned this Oct 2, 2023
@stephengillie
Copy link
Collaborator

Hi @ruevs,

This PR fell through the cracks - very sorry about that.

@stephengillie
Copy link
Collaborator

@wingetbot waivers Add Validation-Missing-Dependency

@wingetbot
Copy link
Collaborator

Invalid arguments for command waivers with action add Received 'Add Validation-Missing-Dependency'

wingetbot command waivers supported actions

  • add:
    • Add a temporary waiver for the specified labels.
    • Example: @wingetbot waivers add Policy-Test-2.7 Validation-Domain
  • remove:
    • Removes a temporary waiver for the specified labels.
    • Example: @wingetbot waivers remove Policy-Test-2.7 Validation-Domain
  • help:
    • Displays this help.
    • Example: @wingetbot waivers help

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Oct 3, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 0e5bdb6 into microsoft:master Oct 3, 2023
7 checks passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Dependencies Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed Waived-Validation-Executable-Error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants