Registering Git Profile for Windows Terminal on Git.Git manifests #110011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wingetbot
added
the
Internal-Error-Dynamic-Scan
|
Hello @BrandonWanHuanSheng, The pull request encountered an internal error and has been assigned to a developer to investigate. Template: msftbot/validationError/internalError |
microsoft-github-policy-service
bot
added
the
Needs-Attention
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
microsoft-github-policy-service
bot
removed
Internal-Error-Dynamic-Scan
BrandonWanHuanSheng
changed the title
mwisnicki
reviewed
Jun 17, 2023
wingetbot
added
the
Internal-Error-Dynamic-Scan
|
Hello @BrandonWanHuanSheng, The pull request encountered an internal error and has been assigned to a developer to investigate. Template: msftbot/validationError/internalError |
microsoft-github-policy-service
bot
added
the
Needs-Attention
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
microsoft-github-policy-service
bot
removed
the
Internal-Error-Dynamic-Scan
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
microsoft-github-policy-service
bot
removed
Needs-Attention
wingetbot
added
the
Internal-Error-Dynamic-Scan
|
Hello @BrandonWanHuanSheng, The pull request encountered an internal error and has been assigned to a developer to investigate. Template: msftbot/validationError/internalError |
microsoft-github-policy-service
bot
added
the
Needs-Attention
stephengillie
added
Validation-Completed
|
BrandonWanHuanSheng, The check-in policies require a moderator to approve PRs from the community. Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission. Template: msftbot/requiresApproval/moderator |
stephengillie
approved these changes
Jun 19, 2023
microsoft-github-policy-service
bot
added
the
Moderator-Approved
![microsoft-github-policy-service[bot]](https://avatars.githubusercontent.com/in/95686?s=60&v=4){kind=small}
|
Hello BrandonWanHuanSheng, Template: msftbot/validationCompleted |
|
Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present. |
derrickstolee
added a commit
to derrickstolee/winget-pkgs
that referenced
this pull request
Aug 9, 2023
These arguments are intended to tell the installer to be as quiet as possible. * /SUPPRESSMSGBOXES indicates that the installer should not create pop-up windows when an issue arises. Instead, the installer will fail. This will resolve microsoft/git#595. * "/enable-component windowsterminal" was added to the Git/Git manifest in microsoft#110011 to resolve microsoft#109915, which was creating some installation problems on Windows 10. Signed-off-by: Derrick Stolee <[email protected]>
microsoft-github-policy-service bot
pushed a commit
that referenced
this pull request
Aug 10, 2023
* microsoft/git: add custom installer arguments These arguments are intended to tell the installer to be as quiet as possible. * /SUPPRESSMSGBOXES indicates that the installer should not create pop-up windows when an issue arises. Instead, the installer will fail. This will resolve microsoft/git#595. * "/enable-component windowsterminal" was added to the Git/Git manifest in #110011 to resolve #109915, which was creating some installation problems on Windows 10. Signed-off-by: Derrick Stolee <[email protected]> * microsoft/git: match some format for Git/Git's manifest The Git/Git manifest has some additional options that were created directly by the Winget team, as opposed to microsoft/git which was created by the Git team. Since the Winget team is likely better at this sort of thing, adopt some of the choices made over there. These are mostly innocuous, though there is one interesting difference that still remains: the Git/Git manifest has two installers with different 'Scope' values ('machine' and 'user') while microsoft/git is only available via 'machine' scope. This is purposefully left alone since there is no difference in how the installers are specified and we are not sure we want to support user-only installs of microsoft/git. Signed-off-by: Derrick Stolee <[email protected]> --------- Signed-off-by: Derrick Stolee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
winget validate --manifest <path>?winget install --manifest <path>?Note:
<path>is the name of the directory containing the manifest you're submitting.Resolves #109915
Microsoft Reviewers: codeflow:open?pullrequest=#110011