Workaround for accessing public folder from extensions #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamespik
reviewed
Apr 30, 2020
jedieaston
added a commit
to jedieaston/winget-cli
that referenced
this pull request
Nov 17, 2021
2dfc7499 Update Authors file 6dab4978 Update README and tweak syntax in Boost.JSON adapter 2ecd2119 Merge pull request microsoft#136 from matty0ung/boostjson b1119ccc Merge pull request microsoft#135 from matty0ung/uris f5cf601e Add Boost.JSON support 14325788 Add Boost.JSON support d3104ea8 Support fetching sub-schemas from other files ad7dac75 Merge pull request microsoft#133 from rayvincent2/feature/add-urn-reference-support 3442709a Update urn regex expression to be std::regex safe f787a8a7 Update urn regex to match widely accepted expression 653d515d Ensure that urn regex checks to end of string eac0859c Ensure that urn NID cannot include '.' ef42dae2 Add support for urn document references a4684c28 Fix path to rapidjson in fuzzing test code 11af6522 Merge remote-tracking branch 'clainio/build-fix' c5487c39 Update rapidjson to latest code from github 6a04040d Update adapters to avoid inheriting from std::iterator 385d2d83 Improve handling of compiler flags when exceptions are disabled 82e093fe Upgrade gtest to v1.11.0 c63ac26f Disable C4702: unreachable code warnings for json_pointer.hpp 855365bc Disable C4702: unreachable code warnings within relevant headers 5c97e3cc Fix gcc build error 4897d102 Fix exclusiveMaximum and exclusiveMinimum error messages 6cc4cddc Suppress boost warnings that aren't relevant to the test suite 2cf8d3dd Add default tests for draft 7 e94179e1 Add definitions tests for draft 7 bb2c4251 Improve array_iteration_basics example e6909b15 Add required test for draft 4 df89869e Add maxLength and minLength tests for draft 7 91834621 Fix return type on getMinLength 3740dc51 Explicitly initialise optionals in Subschema class cb778b6b Minor changes to address msvc warnings and make cmake work on Windows 70f12ed1 Merge pull request microsoft#123 from anishmonachan7/fix_unused_variable 03b8cccb Update include/valijson/constraints/concrete_constraints.hpp dc6d2fe0 fix unused variable error with gcc 8.3 77bae9fb Fix xcode stuff 66262baf Include nlohmann/json.hpp instead of json.hpp b3b958c8 Merge pull request microsoft#121 from anishmonachan7/virtual_destructor 84c9fbf5 destructor to virtual destructor 8a784f23 Minor fix for example code in README a19e1c00 Remove warning suppressions for clang af2358b6 Use custom RAPIDJSON_ASSERT macro to catch parser errors 7ab96207 Ensure ref values are strings 635f36f0 Merge pull request microsoft#119 from BSipos-RKF/issue-118 fba5a9e8 Reject JSON references that index into empty arrays cbcde15c Possible fix for microsoft#118 3621f98d Update rapidjson_utils.hpp to use iterative parsing f544cd02 Merge pull request microsoft#116 from AdamKorcz/fuzz1 c13eed99 Minor refactoring 3a47f0cd Added fuzzer with oss-fuzz build file cf648930 Merge pull request microsoft#114 from baylesj/fix-memory-leak 1f964c12 Fix memory leak in concrete constraints 7cb31947 Merge pull request microsoft#113 from hei-pa/master 8cc83c8b move curlpp findPackage in EXAMPLES block c1e75c70 Merge pull request microsoft#110 from baylesj/remote_throws bc81adbd add version checks around BOOST_NORETURN 7a560db2 Fixup headers b8e95810 Apply feedback, add boost version check 8f6f9b6a Use deprecated declarations f1006142 Cleanup unnecessary returns a30ef974 Add VALIJSON_USE_EXCEPTIONS mode 8a700811 Add JSON Inspector example app bbfc3f5c Fixed build on certain GCC toolchains 84b67fa6 Merge pull request microsoft#107 from baylesj/readme 90783ca4 Minor code style changes 3dd4482a Merge pull request microsoft#103 from wwriter/cond_schema_errormessage ee4f85bf Minor tweaks to README.md file a7038862 Update jsoncpp link in readme abedaf0e Merge pull request microsoft#105 from baylesj/update-jsoncpp 825ee110 Fix readme b6b6f167 Delete jsoncpp fuzzing stuff 2ee7474f Delete more unnecessary scripts 1ff5308f fix submodule dbc4fcc8 Remove modules 88d9d890 Update JsonCpp to 1.9.4 d5091b2d added feature : now users can get a detailed error message when if-then-else conditional constraints are not met 931f64d4 Merge pull request microsoft#102 from mathbunnyru/patch-2 c5e61543 Add conan package manager info 6cda9227 Merge pull request microsoft#99 from mathbunnyru/patch-1 45b0f83b Fix README so the code actually throws, when json is invalid 89e37cbf Fix typo 7f01c391 Minor suggestions from clangtidy a527564b Merge pull request microsoft#96 from joshuaeckroth/master ccad6b14 Switched from jsoncpp deprecated Reader to CharReader 45a333e6 Try to make builds faster 0ee3bada Fix broken build bbe62ecd Merge pull request microsoft#95 from wirenboard/feature/cache-regex f7f3acf2 Merge pull request microsoft#94 from wirenboard/fix/pass-by-ref 39f35069 Regex objects cache for pattern constraints 2216c2b8 Pass visitor to validationCallback by ref 0db0d139 Merge pull request microsoft#93 from Delgan/fix-unused-args 1c825cc6 Remove unused parameters instead of commenting them out ca031221 Fix compilation errors due to unused parameters 105e345a Merge pull request microsoft#92 from arthurafarias/add-cmake-interface-library f60a3089 Added interface target to CMakeLists.txt d453ee2e Revert breaking changes to jsoncpp_adapter.hpp f3a0390e Revert changes to json11_adapter.hpp 49c20301 Disable -Wshadow for included header in property_tree_utils.hpp 8875d802 Add CLion paths to .gitignore 73a8e440 More aggressive compiler warnings 77d2ef82 Cosmetic improvements for poco_json_adapter.hpp and property_tree_adapter.hpp e5c1cbfe Ensure tests are run for Poco, Qt and property_tree adapters 8c0d16a0 Cosmetic improvements for std_string_adapter.hpp, test_json_pointer.cpp and test_poly_constraint.cpp 217b990b Cosmetic improvements for schema_parser.hpp and validation_results.hpp 71f4cdaa Cosmetic improvements for custom_allocator.hpp e46af245 Cosmetic improvements for concrete_constraints.hpp and basic_constraint.hpp 7917b2f7 Cosmetic improvements for schema.hpp, schema_parser.hpp and subschema.hpp 8150a520 Cosmetic improvements for test_adapter_comparison.cpp 28cc9e8e Cosmetic improvements for qtjson_adapter.hpp 508bc019 Cosmetic improvements for rapidjson_adapter.hpp d7901d48 Cosmetics improvements for picojson_adapter.hpp 3211a04d Cosmetic improvements for nlohmann_json_adapter.hpp 0f57cb31 Cosmetic improvements for jsoncpp_adapter.hpp e11c17c3 Cosmetic improvements for json11_adapter.hpp 6f1f4acb Cosmetic improvements for basic_adapter.hpp 3ddbe585 Cosmetic improvements for validation_visitor.hpp 09d21423 Update xcode project files 0481a0bb Minor tidy up of const auto usage 94cef2fa Add example showing local file resolution git-subtree-dir: src/Valijson/valijson git-subtree-split: 2dfc7499a31b84edef71189f4247919268ebc74e
jedieaston
added a commit
to jedieaston/winget-cli
that referenced
this pull request
Nov 17, 2021
2dfc7499 Update Authors file 6dab4978 Update README and tweak syntax in Boost.JSON adapter 2ecd2119 Merge pull request microsoft#136 from matty0ung/boostjson b1119ccc Merge pull request microsoft#135 from matty0ung/uris f5cf601e Add Boost.JSON support 14325788 Add Boost.JSON support d3104ea8 Support fetching sub-schemas from other files ad7dac75 Merge pull request microsoft#133 from rayvincent2/feature/add-urn-reference-support 3442709a Update urn regex expression to be std::regex safe f787a8a7 Update urn regex to match widely accepted expression 653d515d Ensure that urn regex checks to end of string eac0859c Ensure that urn NID cannot include '.' ef42dae2 Add support for urn document references a4684c28 Fix path to rapidjson in fuzzing test code 11af6522 Merge remote-tracking branch 'clainio/build-fix' c5487c39 Update rapidjson to latest code from github 6a04040d Update adapters to avoid inheriting from std::iterator 385d2d83 Improve handling of compiler flags when exceptions are disabled 82e093fe Upgrade gtest to v1.11.0 c63ac26f Disable C4702: unreachable code warnings for json_pointer.hpp 855365bc Disable C4702: unreachable code warnings within relevant headers 5c97e3cc Fix gcc build error 4897d102 Fix exclusiveMaximum and exclusiveMinimum error messages 6cc4cddc Suppress boost warnings that aren't relevant to the test suite 2cf8d3dd Add default tests for draft 7 e94179e1 Add definitions tests for draft 7 bb2c4251 Improve array_iteration_basics example e6909b15 Add required test for draft 4 df89869e Add maxLength and minLength tests for draft 7 91834621 Fix return type on getMinLength 3740dc51 Explicitly initialise optionals in Subschema class cb778b6b Minor changes to address msvc warnings and make cmake work on Windows 70f12ed1 Merge pull request microsoft#123 from anishmonachan7/fix_unused_variable 03b8cccb Update include/valijson/constraints/concrete_constraints.hpp dc6d2fe0 fix unused variable error with gcc 8.3 77bae9fb Fix xcode stuff 66262baf Include nlohmann/json.hpp instead of json.hpp b3b958c8 Merge pull request microsoft#121 from anishmonachan7/virtual_destructor 84c9fbf5 destructor to virtual destructor 8a784f23 Minor fix for example code in README a19e1c00 Remove warning suppressions for clang af2358b6 Use custom RAPIDJSON_ASSERT macro to catch parser errors 7ab96207 Ensure ref values are strings 635f36f0 Merge pull request microsoft#119 from BSipos-RKF/issue-118 fba5a9e8 Reject JSON references that index into empty arrays cbcde15c Possible fix for microsoft#118 3621f98d Update rapidjson_utils.hpp to use iterative parsing f544cd02 Merge pull request microsoft#116 from AdamKorcz/fuzz1 c13eed99 Minor refactoring 3a47f0cd Added fuzzer with oss-fuzz build file cf648930 Merge pull request microsoft#114 from baylesj/fix-memory-leak 1f964c12 Fix memory leak in concrete constraints 7cb31947 Merge pull request microsoft#113 from hei-pa/master 8cc83c8b move curlpp findPackage in EXAMPLES block c1e75c70 Merge pull request microsoft#110 from baylesj/remote_throws bc81adbd add version checks around BOOST_NORETURN 7a560db2 Fixup headers b8e95810 Apply feedback, add boost version check 8f6f9b6a Use deprecated declarations f1006142 Cleanup unnecessary returns a30ef974 Add VALIJSON_USE_EXCEPTIONS mode 8a700811 Add JSON Inspector example app bbfc3f5c Fixed build on certain GCC toolchains 84b67fa6 Merge pull request microsoft#107 from baylesj/readme 90783ca4 Minor code style changes 3dd4482a Merge pull request microsoft#103 from wwriter/cond_schema_errormessage ee4f85bf Minor tweaks to README.md file a7038862 Update jsoncpp link in readme abedaf0e Merge pull request microsoft#105 from baylesj/update-jsoncpp 825ee110 Fix readme b6b6f167 Delete jsoncpp fuzzing stuff 2ee7474f Delete more unnecessary scripts 1ff5308f fix submodule dbc4fcc8 Remove modules 88d9d890 Update JsonCpp to 1.9.4 d5091b2d added feature : now users can get a detailed error message when if-then-else conditional constraints are not met 931f64d4 Merge pull request microsoft#102 from mathbunnyru/patch-2 c5e61543 Add conan package manager info 6cda9227 Merge pull request microsoft#99 from mathbunnyru/patch-1 45b0f83b Fix README so the code actually throws, when json is invalid 89e37cbf Fix typo 7f01c391 Minor suggestions from clangtidy a527564b Merge pull request microsoft#96 from joshuaeckroth/master ccad6b14 Switched from jsoncpp deprecated Reader to CharReader 45a333e6 Try to make builds faster 0ee3bada Fix broken build bbe62ecd Merge pull request microsoft#95 from wirenboard/feature/cache-regex f7f3acf2 Merge pull request microsoft#94 from wirenboard/fix/pass-by-ref 39f35069 Regex objects cache for pattern constraints 2216c2b8 Pass visitor to validationCallback by ref 0db0d139 Merge pull request microsoft#93 from Delgan/fix-unused-args 1c825cc6 Remove unused parameters instead of commenting them out ca031221 Fix compilation errors due to unused parameters 105e345a Merge pull request microsoft#92 from arthurafarias/add-cmake-interface-library f60a3089 Added interface target to CMakeLists.txt d453ee2e Revert breaking changes to jsoncpp_adapter.hpp f3a0390e Revert changes to json11_adapter.hpp 49c20301 Disable -Wshadow for included header in property_tree_utils.hpp 8875d802 Add CLion paths to .gitignore 73a8e440 More aggressive compiler warnings 77d2ef82 Cosmetic improvements for poco_json_adapter.hpp and property_tree_adapter.hpp e5c1cbfe Ensure tests are run for Poco, Qt and property_tree adapters 8c0d16a0 Cosmetic improvements for std_string_adapter.hpp, test_json_pointer.cpp and test_poly_constraint.cpp 217b990b Cosmetic improvements for schema_parser.hpp and validation_results.hpp 71f4cdaa Cosmetic improvements for custom_allocator.hpp e46af245 Cosmetic improvements for concrete_constraints.hpp and basic_constraint.hpp 7917b2f7 Cosmetic improvements for schema.hpp, schema_parser.hpp and subschema.hpp 8150a520 Cosmetic improvements for test_adapter_comparison.cpp 28cc9e8e Cosmetic improvements for qtjson_adapter.hpp 508bc019 Cosmetic improvements for rapidjson_adapter.hpp d7901d48 Cosmetics improvements for picojson_adapter.hpp 3211a04d Cosmetic improvements for nlohmann_json_adapter.hpp 0f57cb31 Cosmetic improvements for jsoncpp_adapter.hpp e11c17c3 Cosmetic improvements for json11_adapter.hpp 6f1f4acb Cosmetic improvements for basic_adapter.hpp 3ddbe585 Cosmetic improvements for validation_visitor.hpp 09d21423 Update xcode project files 0481a0bb Minor tidy up of const auto usage 94cef2fa Add example showing local file resolution git-subtree-dir: src/Valijson/valijson git-subtree-split: 2dfc7499a31b84edef71189f4247919268ebc74e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Due to the current signing strategy for PPE and Prod environments, a license check is being performed on the package when we attempt to get the public folder. For now, work around that issue by constructing the path ourselves. As this was already required for the non-packaged path, we can fix both when possible in the future. But for the time being the directory must be called "Public" within the extension package.
Testing
Regression tests.