Create DB 1.1 schema for system reference strings #564
Conversation
…d removes more of them when packaging
| // Interface to this schema version exposed through ISQLiteIndex. | ||
| struct Interface : public V1_0::Interface | ||
| { | ||
| // Version 1.0 |
There was a problem hiding this comment.
1.0 [](start = 19, length = 3)
1.1? #ByDesign
There was a problem hiding this comment.
No, this 1.0 refers to the interface version where the functions come from. These are 1.0 functions. If 1.1 added new accessor functions, they would be in a 1.1 section. #ByDesign
| }; | ||
| } | ||
|
|
||
| // The table for PackageFamilyName. |
There was a problem hiding this comment.
PackageFamilyName [](start = 21, length = 17)
Nit: wrong description
#Resolved
| auto foldIfNeeded = [](ApplicationMatchFilter& filter) | ||
| { | ||
| if ((filter.Field == ApplicationMatchField::PackageFamilyName || filter.Field == ApplicationMatchField::ProductCode) && | ||
| filter.Type == MatchType::Exact) |
There was a problem hiding this comment.
filter.Type == MatchType::Exact [](start = 16, length = 31)
Should we just fold regardless of Matchtype for these 2 fields? #ByDesign
There was a problem hiding this comment.
The other MatchTypes use like for comparison, and so get folded as part of that. While it wouldn't hurt anything, it isn't necessary.
In reply to: 488313354 [](ancestors = 488313354)
|
|
||
| if (!bindIndex) | ||
| { | ||
| AICLI_LOG(Repo, Verbose, << "ApplicationMatchField not supported in this version: " << ApplicationMatchFieldToString(field)); |
There was a problem hiding this comment.
"ApplicationMatchField not supported in this version: " [](start = 40, length = 55)
Do we want to surface this back to user in some form? #ByDesign
There was a problem hiding this comment.
No, this is how a 1.0 database will avoid attempting to search for the new fields. It is an intended short circuit, but is logged for informational purposes.
In reply to: 488314712 [](ancestors = 488314712)
| @@ -51,6 +51,10 @@ namespace AppInstaller::Repository::Microsoft | |||
| // Gets the schema version of the index. | |||
| Schema::Version GetVersion() const { return m_version; } | |||
|
|
|||
| // Changes the version of the interface being used to operate on the database. | |||
| // Should only be used for testing. | |||
| void ForceVersion(const Schema::Version& version); | |||
There was a problem hiding this comment.
void ForceVersion(const Schema::Version& version); [](start = 8, length = 50)
should we put it inside existing #def DISABLE***TEST_HOOK since it's test only? #Resolved
| @@ -66,6 +66,12 @@ namespace AppInstaller::Manifest | |||
| // Store Product Id | |||
| string_t ProductId; | |||
|
|
|||
| // Package family name for MSIX type only. | |||
There was a problem hiding this comment.
MSIX [](start = 35, length = 5)
or Store type? #Resolved
|
Related to #1243 |
Change
The primary motivation of this change was to add new fields for use in the list and upgrade commands; system reference strings that can be used to associate a winget package with software currently installed on a machine. This required creation of schema 1.1, as well as some refactoring to make inheritance and behavior changes easier between versions.
The two types of strings added are PackageFamilyName for MSIX packages, and ProductCode for packages that register through ARP (Add/Remove Programs). These are added with the option of having multiple of each in the event that a package's installers have unique values. The values are stored with their casing folded to allow for ordinal comparisons, a performance requirement due to future work on list and upgrade.
Additional noteworthy changes:
Validation
The existing tests have been updated to use GENERATE to run the tests not only against all versions, but also with backcompat scenarios.
Microsoft Reviewers: Open in CodeFlow