Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove attribute in DSC #4932

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Remove attribute in DSC #4932

merged 2 commits into from
Oct 31, 2024

Conversation

JohnMcPMS
Copy link
Member

@JohnMcPMS JohnMcPMS commented Oct 31, 2024

Change

Removes the attribute ValidateNotNullOrWhiteSpace as it is only available starting in 7.4. The attributes also only validate when the value is assigned, so enforcing that a value is set is more complete.

Validation

Loads in PS 7.2.8 now.

Microsoft Reviewers: Open in CodeFlow

@JohnMcPMS JohnMcPMS requested a review from a team as a code owner October 31, 2024 20:41
@denelon
Copy link
Contributor

denelon commented Oct 31, 2024

@JohnMcPMS JohnMcPMS merged commit 03587c2 into microsoft:master Oct 31, 2024
9 checks passed
@JohnMcPMS JohnMcPMS deleted the repair-deps branch October 31, 2024 22:51
JohnMcPMS added a commit to JohnMcPMS/winget-cli that referenced this pull request Oct 31, 2024
## Change
Removes the attribute `ValidateNotNullOrWhiteSpace` as it is only
available starting in 7.4. The attributes also only validate when the
value is assigned, so enforcing that a value is set is more complete.

## Validation
Loads in PS 7.2.8 now.
ryfu-msft pushed a commit that referenced this pull request Oct 31, 2024
## Change
Removes the attribute `ValidateNotNullOrWhiteSpace` as it is only
available starting in 7.4. The attributes also only validate when the
value is assigned, so enforcing that a value is set is more complete.

## Validation
Loads in PS 7.2.8 now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants