Skip uninstall attempt when installed package version is not present #4685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florelis
previously approved these changes
Jul 29, 2024
JohnMcPMS
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
florelis
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We are seeing crashes from the installed package version being null, but only during upgrades with a dependency when attempting to uninstall said dependency (either due to user request or manifest).
Change
Simply exit the two workflow tasks involved with the uninstall if the installed package version is not present.
Validation
Added a new test to exercise an upgrade that adds a dependency that is not installed and that dependency has
UpgradeBehavior: uninstallPrevious.Microsoft Reviewers: Open in CodeFlow