Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerShell Help for Microsoft.WinGet.Client #4674

Merged
merged 58 commits into from
Aug 13, 2024

Conversation

denelon
Copy link
Contributor

@denelon denelon commented Jul 24, 2024

Resolves: #4673

Related to:

Microsoft Reviewers: Open in CodeFlow

This comment was marked as outdated.

This comment has been minimized.

This comment has been minimized.

@denelon denelon changed the title Power shell help PowerShell Help for Microsoft.WinGet.Client Jul 26, 2024
Copy link

@sdwheeler sdwheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More comments and suggestions.

More to come tomorrow.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Author-Feedback Issue needs attention from issue or PR author and removed Needs-Author-Feedback Issue needs attention from issue or PR author labels Aug 8, 2024
@denelon denelon marked this pull request as ready for review August 8, 2024 18:47
Copy link

@sdwheeler sdwheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More changes and comments. One more batch to follow.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback Issue needs attention from issue or PR author label Aug 8, 2024
Copy link

@sdwheeler sdwheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final review pass. See comments and suggestions.

This comment has been minimized.


This command uninstalls a WinGet package from your computer. The command includes parameters to
specify values used to search for installed packages. By default, all string-based searches are
case-insensitive substring searches. Wildards are not supported. You can change the search behavior

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
case-insensitive substring searches. Wildards are not supported. You can change the search behavior
case-insensitive substring searches. Wildcards are not supported. You can change the search behavior


### -Custom

Use this paramater to pass additional arguments to the installer. The parameter takes a single

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Use this paramater to pass additional arguments to the installer. The parameter takes a single
Use this parameter to pass additional arguments to the installer. The parameter takes a single

This command searches the packages installed on your system and installs a newer version of the
matching WinGet package. The command includes parameters to specify values used to search for
packages in the configured sources. By default, the command searches all sources. By default, all
string-based searches are case-insensitive substring searches. Wildards are not supported. You can

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
string-based searches are case-insensitive substring searches. Wildards are not supported. You can
string-based searches are case-insensitive substring searches. Wildcards are not supported. You can


### -Custom

Use this paramater to pass additional arguments to the installer. The parameter takes a single

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Use this paramater to pass additional arguments to the installer. The parameter takes a single
Use this parameter to pass additional arguments to the installer. The parameter takes a single


### -Log

Specify log location for uninstall.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Specify log location for uninstall.
Specify the location for the installer log. The value can be a fully-qualified or relative path and
must include the file name. For example: `$env:TEMP\package.log`.


### -Log

Specify the location for the installer log to be written.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Specify the location for the installer log to be written.
Specify the location for the installer log. The value can be a fully-qualified or relative path and
must include the file name. For example: `$env:TEMP\package.log`.

This comment has been minimized.

florelis
florelis previously approved these changes Aug 9, 2024

### -Argument

The URL or UNC of WinGet source. The source must respond with the WinGet REST source API.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the WinGet REST source API

Doesn't this also support the preindexed sources?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the description to include preindexed sources

- InstallerHashOverride
- LocalArchiveMalwareScanOverride
- ProxyCommandLineOptions
- DefaultProxy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I had seen a previous comment about this, but DefaultProxy is not a flag that is enabled/disabled, so I don't think it works with this cmdlet

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed DefaultProxy from this list.


This command lists all of the packages installed on your system. The output includes packages
installed from WinGet sources and packages installed by other methods. Packages that have package
identifiers starting with `MSIX` or `ARP` were not installed from a WinGet source.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think there are cases where a package installed from a WinGet source may not be correlated back to it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't address this as I'm not quite sure how to best explain this.. 😓


This command displays the WinGet settings for the current user. The settings are stored in
`$env:LOCALAPPDATA\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\settings.json`.
This file only exists if you have change a user setting using the `Set-WinGetUserSettings` command.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not the only way settings can be changed. Maybe "...if you have changed a user setting, for example, using..."?

Comment on lines 344 to 350
### -Override

Specify arguments to pass to the installer as a single string. To pass multiple arguments, include
the arguments in the string. The arguments must be provided in the format expected by the installer.
If the string contains spaces, it must be enclosed in quotes. This string overrides the arguments in
the package manifest.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we clarify the difference with -Custom?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated description for both -Custom and -Override to clarify the difference

Comment on lines 23 to 24
This command removes a configured WinGet source. By default, there are two sources registered:
`msstore` and `winget`. You can add more sources using `Add-WinGetSource`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be run as admin, right? Maybe we should clarify it like for other commands.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added description that add/remove source commands must be run as admin.


## DESCRIPTION

This command repairs the installation of the WinGet client on your computer by installing the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me think it only works if it is already installed, but it can also be used to install if it is missing, right? Should we clarify?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated description.

.github/actions/spelling/expect.txt Outdated Show resolved Hide resolved
.github/actions/spelling/expect.txt Outdated Show resolved Hide resolved
@ryfu-msft
Copy link
Contributor

/azp run

- InstallerHashOverride
- LocalArchiveMalwareScanOverride
- ProxyCommandLineOptions
- DefaultProxy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- DefaultProxy

Needs to be removed in Disable cmdlet as well

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will address this in another PR

@jsoref
Copy link
Contributor

jsoref commented Aug 12, 2024

If people want to enforce "please use contractions", this comment includes the rough changes: #4674 (comment)

@ryfu-msft ryfu-msft merged commit 5427597 into microsoft:master Aug 13, 2024
7 of 9 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention Issue needs attention from Microsoft Needs-Author-Feedback Issue needs attention from issue or PR author labels Aug 13, 2024
@denelon denelon deleted the PowerShellHelp branch August 26, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Docs It's a documentation issue that really should be on MicrosoftDocs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add platyPS documentation for Microsoft.WinGet.Client
8 participants