Add support for optional limitation set in configuration remote server and processors #4349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
JohnMcPMS
reviewed
Apr 4, 2024
src/Microsoft.Management.Configuration.Processor/Extensions/ValueSetExtensions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Management.Configuration.Processor/Extensions/ValueSetExtensions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Management.Configuration.Processor/Set/ConfigurationSetProcessor.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Management.Configuration.Processor/Set/ConfigurationSetProcessor.cs
Outdated
Show resolved
Hide resolved
JohnMcPMS
approved these changes
Apr 5, 2024
ryfu-msft
pushed a commit
to ryfu-msft/winget-cli
that referenced
this pull request
Apr 8, 2024
…r and processors (microsoft#4349) Added support for optional limitation set in configuration remote server and processors. When running in limitation mode, incoming units would need to match units in limitation set. And units can only be asserted or applied once. Added tests. And some hacky manual verification. E2E tests will come along when calling side is updated in separate pr. Also updated .net target OS version to 22000 to match other parts. (I thought there was a bug in IInputStreamAdaptor for MemoryStream)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for optional limitation set in configuration remote server and processors. When running in limitation mode, incoming units would need to match units in limitation set. And units can only be asserted or applied once.
Added tests. And some hacky manual verification. E2E tests will come along when calling side is updated in separate pr.
Also updated .net target OS version to 22000 to match other parts. (I thought there was a bug in IInputStreamAdaptor for MemoryStream)
Microsoft Reviewers: Open in CodeFlow