Allow multiple apps in a single command #2861

florelis · 2023-01-17T20:59:26Z

This change adds support specifying multiple packages in a single command for install, update and uninstall. For example, winget install app1 app2.

Added a new argument type called MultiQuery, which is the same as Query but has a limit for values larger than 1. Thankfully the arg parsing was already implemented :)
Used this new argument in the install, upgrade and uninstall commands. The first step in these commands is now to check if MultiQuery has more than 1 value, and if it doesn't it is replaced by a single Query argument. This way, the change is not visible to existing code.
If there is more than one value for the multi-query argument, we proceed to search for each query in a separate sub-query, and then we install them all one at a time. The code for this is refactored from the import flow which does pretty much the same thing.
Added unit tests for these 3 commands.

I did not extend argument validation in this PR. Ideally we would block arguments that don't make sense for more than one package when doing multi-queries, like --override. I will send a separate PR to refactor the argument validation to make this easier without repeating it in the three commands.

Closes #219

Microsoft Reviewers: Open in CodeFlow

src/AppInstallerCLICore/Commands/InstallCommand.cpp

Trenly · 2023-01-17T21:17:01Z

src/AppInstallerCLICore/Workflows/MultiQueryFlow.cpp

+        if (!foundAll)
+        {
+            AICLI_LOG(CLI, Info, << "Could not find one or more packages");
+            if (context.Args.Contains(Execution::Args::Type::IgnoreUnavailable))


Does this arg need to be added to install / upgrade in case one of the multiqueries returns no packages? What happens if the user runs winget install 7zip chrome ThisExampleIsNotPresent? Would all packages fail, or would 7zip and chrome still be installed?

It does not need to be added, but we could add it. As it is, it would fail with a message that not all packages were found before installing anything.

Failing is desirable so as to avoid confusion about what installed vs failed!

src/AppInstallerCLICore/ExecutionArgs.h

src/AppInstallerCLICore/Workflows/WorkflowBase.cpp

src/AppInstallerCLICore/Workflows/MultiQueryFlow.cpp

src/AppInstallerCLICore/Command.cpp

florelis · 2023-01-27T22:37:18Z

Only thing pending now should be arg validation, which once I merge #2862 will be only tagging the arg with the right categories. Although it will have to be a special case since it depends on whether it has one or multiple values.

src/AppInstallerCLICore/Commands/InstallCommand.cpp

Trenly · 2023-01-28T00:04:00Z

src/AppInstallerCLICore/Commands/UninstallCommand.cpp

+            {
+                context <<
+                    Workflow::GetMultiSearchRequests <<
+                    Workflow::SearchSubContextsForSingle(Workflow::SearchSubContextsForSingle::SearchPurpose::Uninstall) <<


After reading through this again, it seems like the implementation in #2877 of SearchResultType and the SearchPurpose here are similar; Would it make sense to align them both to SearchPurpose and use it more globally rather than inside the namespace of SearchSubContextsForSingle?

If so, I'll update that PR

src/AppInstallerCLICore/Workflows/WorkflowBase.cpp

src/AppInstallerCLIPackage/Shared/Strings/en-us/winget.resw

src/AppInstallerCLITests/Command.cpp

src/AppInstallerCLICore/Workflows/WorkflowBase.h

src/AppInstallerCLICore/Workflows/WorkflowBase.cpp

yao-msft

# Conflicts: # src/AppInstallerCLICore/Argument.cpp # src/AppInstallerCLICore/Commands/InstallCommand.cpp # src/AppInstallerCLICore/Commands/UninstallCommand.cpp # src/AppInstallerCLICore/Commands/UpgradeCommand.cpp # src/AppInstallerCLICore/ExecutionArgs.h # src/AppInstallerCLICore/Resources.h # src/AppInstallerCLIPackage/Shared/Strings/en-us/winget.resw

emoxam · 2023-02-07T08:15:26Z

When and how ill we get the new release ?

yao-msft · 2023-02-07T19:48:25Z

If you are looking for stable releases, this will be included in v1.5 client release tracked by milestone here https://github.com/microsoft/winget-cli/milestone/39
It is planned to be released around May

If you are looking to test it early, you can join the Windows Insider program to get preview builds, or watch our release page here https://github.com/microsoft/winget-cli/releases

emoxam · 2023-02-08T06:38:31Z

Where can i get Windows Insider program to get preview builds ?

denelon · 2023-02-08T16:50:52Z

https://insider.windows.com/ 😊

emoxam · 2023-02-09T14:13:15Z

I mean - on github there are words Development Releases - "Join the Windows Package Manager Insider program by signing up."
and
"If you decide to install the latest release from GitHub, and you have successfully joined the insider program, you will receive updates when the next development release has been published in the Microsoft Store."
I've joined, and i've got mail a few days ago, but MS store has nothing to give me, i have winget -v
v1.4.10173
and no update so far. What is going on ? Where is a new version? For example this one https://github.com/microsoft/winget-cli/releases/tag/v1.5.101-preview

Trenly · 2023-02-09T14:14:42Z

I mean - on github there are words Development Releases - "Join the Windows Package Manager Insider program by signing up." and "If you decide to install the latest release from GitHub, and you have successfully joined the insider program, you will receive updates when the next development release has been published in the Microsoft Store." I've joined, and i've got mail a few days ago, but MS store has nothing to give me, i have winget -v v1.4.10173 and no update so far. What is going on ? Where is a new version? For example this one v1.5.101-preview (release)

Preview releases aren't cut after every PR. There is internal validation and testing that has to happen before a release is cut. I would think it would be another week or two before these changes are available in a preview

emoxam · 2023-02-09T14:26:10Z

What we gave at store is 1.19.10173 - how does this relate to github versions ? There is no 1.19 at github!

Trenly · 2023-02-09T14:30:18Z

What we gave at store is 1.19.10173 - how does this relate to github versions ? There is no 1.19 at github!

AppInstaller contains winget, but it is not winget itself; The version marked Latest in Github Releases is what is bundled with the AppInstaller from MSStore (unless you're on an insider build)

Trenly · 2023-02-09T14:30:26Z

What we gave at store is 1.19.10173 - how does this relate to github versions ? There is no 1.19 at github!

AppInstaller contains winget, but it is not winget itself; The version marked Latest in Github Releases is what is bundled with the AppInstaller from MSStore (unless you're on an insider build)

emoxam · 2023-02-09T14:32:13Z

So no hope to wait new appinstaller at store ?

florelis · 2023-02-09T19:39:38Z

What we gave at store is 1.19.10173 - how does this relate to github versions ? There is no 1.19 at github!

I know it doesn't seem to make sense, but there is a difference of 15 between the minor version of the App Installer package and the minor version of the winget cli. App Installer v1.19.10173 includes winget v1.4.10173.

This change will come in the preview for winget v1.5, so it will be a App Installer v1.20.

I think it takes some time to start getting preview builds after joining the insider program. Once you see you're on a v1.5 build you'll know you are receiving preview builds, so you should get the one with this change once it's out.

emoxam · 2023-02-10T06:16:38Z

So i should look at store to see if there an update to App Installer v1.20 ?
P.S. Maybe it could be useful to write somewhere at package description what version of wiget it includes ?

florelis added 10 commits January 13, 2023 16:09

Define multi-positional arg type and tests

a82ea46

Normalize line endings

c7005fb

Use existing positional count instead...

a7233a1

Support installing multiple packages in single command

d85202a

Rename file

2cdc88c

Allow uninstalling multiple with one command

f455bd5

Add unit tests

db34ed0

spelling

77b1303

Undo unneeded change

ed96bb1

Remove extra line

5133012

florelis requested a review from a team as a code owner January 17, 2023 20:59

ghost added the Issue-Feature This is a feature request for the Windows Package Manager client. label Jan 17, 2023

florelis mentioned this pull request Jan 17, 2023

Refactor arg validation #2862

Merged

Trenly reviewed Jan 17, 2023

View reviewed changes

florelis added 3 commits January 17, 2023 15:08

Fix arg parsing

1069e6f

Fix failing tests

5dd4949

Update strings in tests

e26b6eb

yao-msft reviewed Jan 20, 2023

View reviewed changes

src/AppInstallerCLICore/Command.cpp Show resolved Hide resolved

florelis added 6 commits January 27, 2023 11:53

if order

73d7f00

RemoveArg()

e27c6e3

Use shared code to create search request for single

22355d1

not found / found multiple

6c0c508

Remove multi query from list

bc882da

Make error more specific

98c5f05

florelis added 4 commits January 27, 2023 14:48

Fix import tests

0ea646d

Fix search request

1d1f25e

Fix expected error codes in tests

2ba14e9

Update expected errors in E2E tests

2ba05d3

Trenly reviewed Jan 28, 2023

View reviewed changes

Trenly mentioned this pull request Jan 30, 2023

Install/Update/Uninstall Multiple Local Manifests #2895

Open

Build error...

f73a2f8

yao-msft reviewed Jan 31, 2023

View reviewed changes

src/AppInstallerCLICore/Workflows/WorkflowBase.h Show resolved Hide resolved

yao-msft reviewed Jan 31, 2023

View reviewed changes

src/AppInstallerCLICore/Workflows/WorkflowBase.cpp Outdated Show resolved Hide resolved

yao-msft approved these changes Jan 31, 2023

View reviewed changes

florelis and others added 6 commits January 31, 2023 14:59

Move logic for converting into single value, add test, add comment

64411f4

Add test for too many positionals

8951acb

Update error strings to be more specific

8ea449f

Fix tests

8674434

Merge branch 'master' into multiinstall

5d8907c

florelis merged commit fcce38f into microsoft:master Feb 6, 2023

florelis deleted the multiinstall branch February 6, 2023 21:52

Trenly mentioned this pull request Feb 6, 2023

Clarify No installed package matching the input criteria was found in upgrade flow #2877

Merged

2 tasks

Trenly mentioned this pull request Jul 24, 2024

add spec for #1620 #2650

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow multiple apps in a single command #2861

Allow multiple apps in a single command #2861

florelis commented Jan 17, 2023 •

edited by ghost

Loading

Trenly Jan 17, 2023

florelis Jan 17, 2023

g0t4 Jun 4, 2023

florelis commented Jan 27, 2023

Trenly Jan 28, 2023

yao-msft left a comment

emoxam commented Feb 7, 2023

yao-msft commented Feb 7, 2023

emoxam commented Feb 8, 2023

denelon commented Feb 8, 2023

emoxam commented Feb 9, 2023

Trenly commented Feb 9, 2023 •

edited

Loading

emoxam commented Feb 9, 2023

Trenly commented Feb 9, 2023

Trenly commented Feb 9, 2023

emoxam commented Feb 9, 2023

florelis commented Feb 9, 2023

emoxam commented Feb 10, 2023

Allow multiple apps in a single command #2861

Allow multiple apps in a single command #2861

Conversation

florelis commented Jan 17, 2023 • edited by ghost Loading

Microsoft Reviewers: Open in CodeFlow

Trenly Jan 17, 2023

Choose a reason for hiding this comment

florelis Jan 17, 2023

Choose a reason for hiding this comment

g0t4 Jun 4, 2023

Choose a reason for hiding this comment

florelis commented Jan 27, 2023

Trenly Jan 28, 2023

Choose a reason for hiding this comment

yao-msft left a comment

Choose a reason for hiding this comment

emoxam commented Feb 7, 2023

yao-msft commented Feb 7, 2023

emoxam commented Feb 8, 2023

denelon commented Feb 8, 2023

emoxam commented Feb 9, 2023

Trenly commented Feb 9, 2023 • edited Loading

emoxam commented Feb 9, 2023

Trenly commented Feb 9, 2023

Trenly commented Feb 9, 2023

emoxam commented Feb 9, 2023

florelis commented Feb 9, 2023

emoxam commented Feb 10, 2023

florelis commented Jan 17, 2023 •

edited by ghost

Loading

Trenly commented Feb 9, 2023 •

edited

Loading