Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare PowerShell Module for Release Build #2768

Merged
merged 8 commits into from
Dec 16, 2022
Merged

Prepare PowerShell Module for Release Build #2768

merged 8 commits into from
Dec 16, 2022

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented Dec 14, 2022 •
edited
Loading

Changes:

  • Sets the appropriate build property in the UndockedRegFreeWinRT project to define USE_PROD_WINGET_SERVER macro.
  • Defaults to x64 architecture for ARM64 machines
  • Reuses 'UseProdCLSIDs' build property instead of creating a new one.
  • Removes Directory.Build.Props file from UndockedRegFreeWinRT project to prevent msbuild property conflicts when creating a release build.
  • Update winrtact.dll path copied from path.
Microsoft Reviewers: Open in CodeFlow

@ryfu-msft ryfu-msft requested a review from a team as a code owner December 14, 2022 21:05
yao-msft
yao-msft approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@yao-msft yao-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ryfu-msft ryfu-msft merged commit 6140e62 into microsoft:master Dec 16, 2022
@ryfu-msft ryfu-msft deleted the preparePowerShellRelease branch February 29, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yao-msft yao-msft yao-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryfu-msft @yao-msft