Make Install flow aware of package installed status #2539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnMcPMS
approved these changes
Oct 6, 2022
| Workflow::GetManifestFromArg << | ||
| Workflow::SelectInstaller << | ||
| Workflow::EnsureApplicableInstaller << | ||
| Workflow::InstallSinglePackage; |
There was a problem hiding this comment.
Shouldn't install from a manifest behave as an upgrade as well (when appropriate)?
| Workflow::EnsureApplicableInstaller << | ||
| Workflow::CheckForUnsupportedArgs << | ||
| Workflow::InstallSinglePackage; | ||
| if (context.Args.Contains(Execution::Args::Type::Manifest)) |
There was a problem hiding this comment.
side note: I've thought that it would be great to collapse the manifest flow into the normal one by making OpenSource create a simple in-memory source for the manifest so that it could behave exactly as everything else.
| @@ -316,7 +316,7 @@ They can be configured through the settings file 'winget settings'.</value> | |||
| <comment>Links to different webpages</comment> | |||
| </data> | |||
| <data name="ListCommandLongDescription" xml:space="preserve"> | |||
| <value>The list command displays the packages installed on the system, as well as whether an update is available. Additional options can be provided to filter the output, much like the search command.</value> | |||
| <value>The list command displays the packages installed on the system, as well as whether an upgrade is available. Additional options can be provided to filter the output, much like the search command.</value> | |||
There was a problem hiding this comment.
Update install command description to include the new behavior of changing to upgrade?
| Workflow::OpenCompositeSource(Repository::PredefinedSource::Installed, false, Repository::CompositeSearchBehavior::AvailablePackages); | ||
| } | ||
|
|
||
| context << Workflow::InstallOrUpgradeSinglePackage(false); |
There was a problem hiding this comment.
Does this also need to be applied to import? More specifically, does import need to be calling InstallOrUpgradeSinglePackage?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow