Mini spec on upcoming install and upgrade flow improvements #2535
Conversation
…es to winget install and winget upgrade flow.md
…es to winget install and winget upgrade flow.md
…es to winget install and winget upgrade flow.md
|
|
||
| - First, winget will try to record selected installer's architecture and locale for installation through winget | ||
| - winget will record architecture or locale from command as user intent. i.e. `winget install foo --architecture x86 --locale en-US` | ||
| - During upgrade flow installer selection, installer architecture or locale from previous installation will be treated as preference. Installer architecture or locale from user intent will be treated as requirement(i.e. the upgrade will fail if architecture or locale requirement cannot be met). |
There was a problem hiding this comment.
| - During upgrade flow installer selection, installer architecture or locale from previous installation will be treated as preference. Installer architecture or locale from user intent will be treated as requirement(i.e. the upgrade will fail if architecture or locale requirement cannot be met). | |
| - During upgrade flow installer selection, installer architecture or locale from previous installation will be treated as preference. Installer architecture or locale from user intent will be treated as requirement (i.e. the upgrade will fail if architecture or locale requirement cannot be met). |
| - winget will record architecture or locale from command as user intent. i.e. `winget install foo --architecture x86 --locale en-US` | ||
| - During upgrade flow installer selection, installer architecture or locale from previous installation will be treated as preference. Installer architecture or locale from user intent will be treated as requirement(i.e. the upgrade will fail if architecture or locale requirement cannot be met). | ||
|
|
||
| **Note**: This improvement only works for installations through winget. Due to current limitations of winget tracking implementation, winget will only honor metadata from last installation for the same package. |
There was a problem hiding this comment.
Has this been thought through for side-by-side architectures? For example, this is what I have on my machine:
PS D:\Git\winget-pkgs> winget list '.NET SDK'
Name Id Version Available
-----------------------------------------------------------------------------------------------------------------
Microsoft .NET SDK 6.0.400 (x64) from Visual Studio {E90155B5-8B75-4892-A27D-D85D131A8E43} 6.4.22.37103
Microsoft .NET SDK 6.0.304 (x64) Microsoft.DotNet.SDK.6 6.0.304 6.0.401
Microsoft .NET SDK 5.0.408 (x64) Microsoft.DotNet.SDK.6 < 6.0.105 6.0.401
Microsoft .NET SDK 6.0.401 (x64) Microsoft.DotNet.SDK.6 6.0.401
Microsoft .NET SDK 6.0.401 (x86) Microsoft.DotNet.SDK.6 6.0.401
Microsoft .NET SDK 6.0.203 (x64) Microsoft.DotNet.SDK.6 6.0.203 6.0.401
Microsoft .NET Core SDK 3.1.423 (x64) Microsoft.DotNet.SDK.3_1 3.1.423
Notice 6.0.401 has both x86 and x64 installed. There isn't a --architecture switch for winget upgrade which is a separate issue altogether. However, I think that both installations would need to be tracked separately or else this will cause #2448 to become even more prominent.
Perhaps I'm thinking too deep into it and these are issues for a different spec. If that's the case, then perhaps some clarity that this does not consider those issues would be appreciated
There was a problem hiding this comment.
Current tracking implementation does not work well with side by side packages, I can clarify it in the Notes: section. Regarding --architecture option, I will add it when implementing the upgrade workflow.
There was a problem hiding this comment.
Sounds good to me; I just wasn't sure how big the scope here actually was. Makes sense that side-by-side is a separate issue
There was a problem hiding this comment.
Yea, current winget code framework is based on 1 installed package to n available packages mapping. This causes winget not handling side by side very well. We're making small improvements here and there to make side by side scenarios better, but to solve the issue completely, the framework needs to be updated to handle n installed package to n available packages mapping.
null
Microsoft Reviewers: Open in CodeFlow