Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default install root #970

Closed
denelon opened this issue May 18, 2021 · 2 comments · Fixed by #1427 or #1814
Closed

Default install root #970

denelon opened this issue May 18, 2021 · 2 comments · Fixed by #1427 or #1814
Labels
Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client.
Milestone

Comments

@denelon
Copy link
Contributor

denelon commented May 18, 2021

Description of the new feature/enhancement

Some packages are installed based on the location of the installer on the drive. This can be an undesired behavior, and may be further complicated by packages with long paths like Python as discovered in microsoft/winget-pkgs#13076.

Proposed technical implementation details (optional)

Extend the manifest to support packages that install based on the location of the installer on the device.
Provide a setting for a default install root location. (/)
Support an argument to specify the install location.
Modify the client to prompt users for an install location when one is required and none is specified in settings.

@denelon denelon added Issue-Feature This is a feature request for the Windows Package Manager client. Area-Manifest This may require a change to the manifest labels May 18, 2021
@ghost ghost added the Needs-Triage Issue need to be triaged label May 18, 2021
@denelon denelon removed the Needs-Triage Issue need to be triaged label May 18, 2021
@denelon
Copy link
Contributor Author

denelon commented Jul 1, 2021

How about:

Installers:
  - InstallerType: exe
    InstallerArchitecture: x64
    InstallerSHA256: 12341234123412341234123412341234123412341234
    InstallerURL: https://www.contoso.com/awesomeapp/1.0.0/awesomeapp.x64.exe
    InstallLocationRequired: boolean

@denelon denelon added this to the v.Next - Windows Package Manager milestone Jul 1, 2021
@denelon
Copy link
Contributor Author

denelon commented Oct 1, 2021

"InstallLocationRequired": {
"type": [ "boolean", "null" ],
"description": "Indicates whether the installer requires an install location provided"
},

@denelon denelon added this to WinGet Oct 1, 2021
@denelon denelon linked a pull request Oct 1, 2021 that will close this issue
@ghost ghost added the In-PR Issue related to a PR label Aug 5, 2022
Repository owner moved this from In Progress to Done in WinGet Aug 12, 2022
@ghost ghost added Resolution-Fix-Committed and removed In-PR Issue related to a PR labels Aug 12, 2022
@denelon denelon modified the milestones: v.Next-Client, v1.5-Client Dec 28, 2022
@denelon denelon added this to the v1.4-Client milestone Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Manifest This may require a change to the manifest Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
Archived in project
1 participant