V1.1 changes to Information endpoint #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamespik
suggested changes
Sep 8, 2021
| }; | ||
|
|
||
| /// <summary> | ||
| /// Unsupported package match fields. | ||
| /// Note: NormalizedPackageNameAndPublisher field is added here to demonstrate how this property can be used. |
There was a problem hiding this comment.
Does the reference implementation support NormalizedPackageNameAndPublisher? If so, disabling it here seems like a problem for anyone looking to standup the reference implementation out of the box.
There was a problem hiding this comment.
Currently Reference impl doesn't have NormalizedPackageNameAndPublisher field support. I have opened an issue for this for future extension.
Closed
jamespik
reviewed
Sep 8, 2021
jamespik
reviewed
Sep 8, 2021
jamespik
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the changes related to V1.1 schema updates for Information Endpoint.
Tests: