Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

CI: Fail on warnings #15

Merged
merged 6 commits into from
Jul 13, 2021
Merged

CI: Fail on warnings #15

merged 6 commits into from
Jul 13, 2021

Conversation

riverar
Copy link
Collaborator

@riverar riverar commented Jul 13, 2021 •
edited by kennykerr
Loading

Fixes #13

@riverar riverar mentioned this pull request Jul 13, 2021
Closed
@wravery
Copy link
Contributor

wravery commented Jul 13, 2021

Here's a fix for the warning then if you want to merge them together so the checks pass: wravery@9f6d426

@riverar riverar requested a review from kennykerr July 13, 2021 20:40
kennykerr
kennykerr approved these changes Jul 13, 2021
View reviewed changes
Copy link
Collaborator

@kennykerr kennykerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@riverar
Copy link
Collaborator Author

riverar commented Jul 13, 2021

We'll stage another PR with Bill's changes

@riverar riverar merged commit 091bf43 into master Jul 13, 2021
@riverar riverar deleted the rafael/ci-fail-on-warnings branch July 13, 2021 20:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kennykerr kennykerr kennykerr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build allows warnings
3 participants
@riverar @wravery @kennykerr