Introducing the dedicated windows-collections crate

.github/workflows/clippy.yml

@@ -305,6 +305,8 @@ jobs:
         run:  cargo clippy -p windows
       - name: Clippy windows-bindgen
         run:  cargo clippy -p windows-bindgen
+      - name: Clippy windows-collections
+        run:  cargo clippy -p windows-collections
       - name: Clippy windows-core
         run:  cargo clippy -p windows-core
       - name: Clippy windows-implement

.github/workflows/msrv-windows-collections.yml

@@ -0,0 +1,32 @@
+name: windows-collections
+
+on:
+  pull_request:
+    paths-ignore:
+      - '.github/ISSUE_TEMPLATE/**'
+      - 'web/**'
+  push:
+    paths-ignore:
+      - '.github/ISSUE_TEMPLATE/**'
+      - 'web/**'
+    branches:
+      - master
+
+jobs:
+  check:
+    strategy:
+      matrix:
+        rust: [1.74.0, stable, nightly]
+        runs-on:
+          - windows-2022
+          - ubuntu-22.04
+    runs-on: ${{ matrix.runs-on }}
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+      - name: Prepare
+        run: rustup update --no-self-update ${{ matrix.rust }} && rustup default ${{ matrix.rust }}
+      - name: Check
+        run: cargo check -p windows-collections --all-features
+      - name: Check Default Features
+        run: cargo check -p windows-collections

.github/workflows/no-default-features.yml

@@ -39,6 +39,8 @@ jobs:
         run:  cargo check -p windows --no-default-features
       - name: Check windows-bindgen
         run:  cargo check -p windows-bindgen --no-default-features
+      - name: Check windows-collections
+        run:  cargo check -p windows-collections --no-default-features
       - name: Check windows-core
         run:  cargo check -p windows-core --no-default-features
       - name: Check windows-implement

.github/workflows/raw-dylib.yml

@@ -336,6 +336,8 @@ jobs:
         run:  cargo test -p windows --target ${{ matrix.target }} ${{ matrix.etc }}
       - name: Test windows-bindgen
         run:  cargo test -p windows-bindgen --target ${{ matrix.target }} ${{ matrix.etc }}
+      - name: Test windows-collections
+        run:  cargo test -p windows-collections --target ${{ matrix.target }} ${{ matrix.etc }}
       - name: Test windows-core
         run:  cargo test -p windows-core --target ${{ matrix.target }} ${{ matrix.etc }}
       - name: Test windows-implement
@@ -362,10 +364,10 @@ jobs:
         run:  cargo test -p windows_aarch64_msvc --target ${{ matrix.target }} ${{ matrix.etc }}
       - name: Test windows_i686_gnu
         run:  cargo test -p windows_i686_gnu --target ${{ matrix.target }} ${{ matrix.etc }}
-      - name: Test windows_i686_gnullvm
-        run:  cargo test -p windows_i686_gnullvm --target ${{ matrix.target }} ${{ matrix.etc }}
       - name: Clean
         run:  cargo clean
+      - name: Test windows_i686_gnullvm
+        run:  cargo test -p windows_i686_gnullvm --target ${{ matrix.target }} ${{ matrix.etc }}
       - name: Test windows_i686_msvc
         run:  cargo test -p windows_i686_msvc --target ${{ matrix.target }} ${{ matrix.etc }}
       - name: Test windows_x86_64_gnu

.github/workflows/test.yml

@@ -333,6 +333,8 @@ jobs:
         run:  cargo test -p windows --target ${{ matrix.target }} ${{ matrix.etc }}
       - name: Test windows-bindgen
         run:  cargo test -p windows-bindgen --target ${{ matrix.target }} ${{ matrix.etc }}
+      - name: Test windows-collections
+        run:  cargo test -p windows-collections --target ${{ matrix.target }} ${{ matrix.etc }}
       - name: Test windows-core
         run:  cargo test -p windows-core --target ${{ matrix.target }} ${{ matrix.etc }}
       - name: Test windows-implement
@@ -359,10 +361,10 @@ jobs:
         run:  cargo test -p windows_aarch64_msvc --target ${{ matrix.target }} ${{ matrix.etc }}
       - name: Test windows_i686_gnu
         run:  cargo test -p windows_i686_gnu --target ${{ matrix.target }} ${{ matrix.etc }}
-      - name: Test windows_i686_gnullvm
-        run:  cargo test -p windows_i686_gnullvm --target ${{ matrix.target }} ${{ matrix.etc }}
       - name: Clean
         run:  cargo clean
+      - name: Test windows_i686_gnullvm
+        run:  cargo test -p windows_i686_gnullvm --target ${{ matrix.target }} ${{ matrix.etc }}
       - name: Test windows_i686_msvc
         run:  cargo test -p windows_i686_msvc --target ${{ matrix.target }} ${{ matrix.etc }}
       - name: Test windows_x86_64_gnu

Cargo.toml

@@ -25,12 +25,13 @@ unexpected_cfgs = { level = "warn", check-cfg = ['cfg(windows_raw_dylib, windows
 cppwinrt = { path = "crates/libs/cppwinrt" }
 windows = { path = "crates/libs/windows" }
 windows-bindgen = { path = "crates/libs/bindgen" }
+windows-collections = { path = "crates/libs/collections" }
 windows-core = { path = "crates/libs/core" }
+windows-link = { path = "crates/libs/link" }
 windows-registry = { path = "crates/libs/registry" }
 windows-result = { path = "crates/libs/result" }
 windows-strings = { path = "crates/libs/strings" }
 windows-sys = { path = "crates/libs/sys" }
 windows-targets = { path = "crates/libs/targets" }
-windows-link = { path = "crates/libs/link" }
 windows-version = { path = "crates/libs/version" }
 helpers = { path = "crates/libs/helpers" }

crates/libs/bindgen/src/type_map.rs

@@ -40,7 +40,7 @@ impl TypeMap {
                             ty.combine(&mut item_dependencies);
                         }
 
-                        if item_dependencies.excluded(filter) {
+                        if item_dependencies.excluded(filter, references) {
                             continue;
                         }
 
@@ -101,7 +101,9 @@ impl TypeMap {
         })
     }
 
-    fn excluded(&self, filter: &Filter) -> bool {
-        self.0.iter().any(|(tn, _)| filter.excludes_type_name(*tn))
+    fn excluded(&self, filter: &Filter, references: &References) -> bool {
+        self.0
+            .iter()
+            .any(|(tn, _)| filter.excludes_type_name(*tn) && references.contains(*tn).is_none())
     }
 }

crates/libs/bindgen/src/types/class.rs

@@ -15,7 +15,7 @@ impl Class {
             return (Cfg::default(), quote! {});
         }
 
-        let cfg = Cfg::new(self.def, &self.dependencies());
+        let cfg = Cfg::new(self.def, &self.dependencies(), writer);
         let tokens = cfg.write(writer, false);
         (cfg, tokens)
     }
@@ -90,7 +90,7 @@ impl Class {
                         let interface_type = interface.write_name(writer);
 
                         let cfg = if writer.config.package {
-                            class_cfg.difference(interface.def, &interface.dependencies()).write(writer, false)
+                            class_cfg.difference(interface.def, &interface.dependencies(), writer).write(writer, false)
                         } else {
                             quote! {}
                         };

crates/libs/bindgen/src/types/cpp_const.rs

@@ -32,7 +32,7 @@ impl CppConst {
             return quote! {};
         }
 
-        Cfg::new(self.field, &self.dependencies()).write(writer, false)
+        Cfg::new(self.field, &self.dependencies(), writer).write(writer, false)
     }
 
     pub fn write(&self, writer: &Writer) -> TokenStream {

crates/libs/bindgen/src/types/cpp_delegate.rs

@@ -38,7 +38,7 @@ impl CppDelegate {
             return quote! {};
         }
 
-        Cfg::new(self.def, &self.dependencies()).write(writer, false)
+        Cfg::new(self.def, &self.dependencies(), writer).write(writer, false)
     }
 
     pub fn write(&self, writer: &Writer) -> TokenStream {

crates/libs/bindgen/src/types/cpp_fn.rs

@@ -65,7 +65,7 @@ impl CppFn {
             return quote! {};
         }
 
-        Cfg::new(self.method, &self.dependencies()).write(writer, false)
+        Cfg::new(self.method, &self.dependencies(), writer).write(writer, false)
     }
 
     pub fn write(&self, writer: &Writer) -> TokenStream {

crates/libs/bindgen/src/types/cpp_interface.rs

@@ -49,7 +49,7 @@ impl CppInterface {
             return (Cfg::default(), quote! {});
         }
 
-        let cfg = Cfg::new(self.def, &self.dependencies());
+        let cfg = Cfg::new(self.def, &self.dependencies(), writer);
         let tokens = cfg.write(writer, false);
         (cfg, tokens)
     }
@@ -83,7 +83,7 @@ impl CppInterface {
 
             let methods = methods.iter().map(|method| match method {
                 CppMethodOrName::Method(method) => {
-                    let method_cfg = class_cfg.difference(method.def, &method.dependencies);
+                    let method_cfg = class_cfg.difference(method.def, &method.dependencies, writer);
                     let yes = method_cfg.write(writer, false);
 
                     let name = names.add(method.def);
@@ -238,7 +238,7 @@ impl CppInterface {
                     }
                 });
 
-                Cfg::new(self.def, &dependencies).write(writer, false)
+                Cfg::new(self.def, &dependencies, writer).write(writer, false)
             } else {
                 quote! {}
             };

crates/libs/bindgen/src/types/cpp_method.rs

@@ -212,7 +212,7 @@ impl CppMethod {
         }
 
         parent
-            .difference(self.def, &self.dependencies)
+            .difference(self.def, &self.dependencies, writer)
             .write(writer, not)
     }
 

crates/libs/bindgen/src/types/cpp_struct.rs

@@ -51,7 +51,7 @@ impl CppStruct {
             return quote! {};
         }
 
-        Cfg::new(self.def, &self.dependencies()).write(writer, false)
+        Cfg::new(self.def, &self.dependencies(), writer).write(writer, false)
     }
 
     pub fn write(&self, writer: &Writer) -> TokenStream {

crates/libs/bindgen/src/types/delegate.rs

@@ -16,7 +16,7 @@ impl Delegate {
             return quote! {};
         }
 
-        Cfg::new(self.def, &self.dependencies()).write(writer, false)
+        Cfg::new(self.def, &self.dependencies(), writer).write(writer, false)
     }
 
     pub fn write(&self, writer: &Writer) -> TokenStream {

crates/libs/bindgen/src/types/interface.rs

@@ -72,7 +72,7 @@ impl Interface {
             return (Cfg::default(), quote! {});
         }
 
-        let cfg = Cfg::new(self.def, &self.dependencies());
+        let cfg = Cfg::new(self.def, &self.dependencies(), writer);
         let tokens = cfg.write(writer, false);
         (cfg, tokens)
     }
@@ -102,7 +102,7 @@ impl Interface {
                     let name = virtual_names.add(method.def);
                     let vtbl = method.write_abi(writer, false);
 
-                    let method_cfg = class_cfg.difference(method.def, &method.dependencies);
+                    let method_cfg = class_cfg.difference(method.def, &method.dependencies, writer);
                     let yes = method_cfg.write(writer, false);
 
                     if yes.is_empty() {
@@ -352,7 +352,7 @@ impl Interface {
                         .iter()
                         .for_each(|interface| combine(interface, &mut dependencies, writer));
 
-                    Cfg::new(self.def, &dependencies).write(writer, false)
+                    Cfg::new(self.def, &dependencies, writer).write(writer, false)
                 } else {
                     quote! {}
                 };

crates/libs/bindgen/src/types/method.rs

@@ -26,7 +26,7 @@ impl Method {
         }
 
         parent
-            .difference(self.def, &self.dependencies)
+            .difference(self.def, &self.dependencies, writer)
             .write(writer, not)
     }
 

crates/libs/bindgen/src/writer/cfg.rs

@@ -38,18 +38,31 @@ pub struct Cfg {
 }
 
 impl Cfg {
-    pub fn new<R: HasAttributes>(row: R, dependencies: &TypeMap) -> Self {
-        let features: BTreeSet<&'static str> =
-            dependencies.keys().map(|tn| tn.namespace()).collect();
+    pub fn new<R: HasAttributes>(row: R, dependencies: &TypeMap, writer: &Writer) -> Self {
+        let features: BTreeSet<&'static str> = dependencies
+            .keys()
+            .filter_map(|tn| {
+                if writer.config.types.contains_key(tn) {
+                    Some(tn.namespace())
+                } else {
+                    None
+                }
+            })
+            .collect();
 
         Self {
             features,
             deprecated: row.has_attribute("DeprecatedAttribute"),
         }
     }
 
-    pub fn difference<R: HasAttributes>(&self, row: R, dependencies: &TypeMap) -> Self {
-        let mut difference = Self::new(row, dependencies);
+    pub fn difference<R: HasAttributes>(
+        &self,
+        row: R,
+        dependencies: &TypeMap,
+        writer: &Writer,
+    ) -> Self {
+        let mut difference = Self::new(row, dependencies, writer);
 
         for feature in &self.features {
             difference.features.remove(feature);

crates/libs/collections/Cargo.toml

@@ -0,0 +1,29 @@
+[package]
+name = "windows-collections"
+version = "0.1.0"
+edition = "2021"
+rust-version = "1.74"
+license = "MIT OR Apache-2.0"
+description = "Windows collection types"
+repository = "https://github.com/microsoft/windows-rs"
+readme = "readme.md"
+
+[lints]
+workspace = true
+
+[package.metadata.docs.rs]
+default-target = "x86_64-pc-windows-msvc"
+targets = []
+
+[dependencies.windows-core]
+version = "0.59.0"
+path = "../core"
+default-features = false
+
+[features]
+default = ["std"]
+std = []
+
+[dev-dependencies]
+windows-result = { path = "../result" }
+windows-strings = { path = "../strings" }