Generalize support for access rights in windows-registry
#3482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great, thanks! I also like that you can now just use |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on #3461, this update generalizes support for access rights so that a caller can request more than just read/write access. I decided against adding an enum declaring the various known access rights as that just leads to the inevitable confusion around which ones to use, how they might be combined, and which obscure access rights to include in the library. If you're unsure just use
read()orwrite()and move on. 😊I also refined the
OpenOptionsto be additive-only to simplify things. So rather than having to sayoptions.read(true).write(true)you can simply sayoptions.read().write()and so on.Fixes: #3474