Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for false dead code warning #3098

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Workaround for false dead code warning #3098

merged 1 commit into from
Jun 13, 2024

Conversation

kennykerr
Copy link
Collaborator

This is a workaround for #3096

ChrisDenton
ChrisDenton approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@ChrisDenton ChrisDenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a very temporary workaround to unblock CI this seems ok but ooph that's really unfortunate.

@kennykerr kennykerr mentioned this pull request Jun 13, 2024
Closed
@kennykerr
Copy link
Collaborator Author

Yep, I'll keep the #3096 issue open as I really don't like this.

@kennykerr kennykerr merged commit 827533f into master Jun 13, 2024
90 checks passed
@kennykerr kennykerr deleted the dead-code-workaround branch June 13, 2024 15:57
mati865 pushed a commit to mati865/windows-rs that referenced this pull request Jun 15, 2024
@kennykerr @mati865
Workaround for false dead code warning (microsoft#3098)
29e5fda
@tgross35 tgross35 mentioned this pull request Jul 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisDenton ChrisDenton ChrisDenton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kennykerr @ChrisDenton