Skip to content

Conversation

@wmmc88
Copy link
Collaborator

@wmmc88 wmmc88 commented Sep 9, 2025

This pull request updates the CI workflow and refactors several test output files to improve code clarity and test execution. The workflow now installs cargo-make and runs additional tests using it. In the test output files, the assertion logic for checking buffer size calculations is refactored to use a more idiomatic match statement for error handling.

CI Workflow Improvements

  • .github/workflows/test.yaml: Adds a step to install cargo-make and introduces a new job to run top-level tests via cargo-make, in addition to the existing workspace tests.

Test Output Refactoring

  • Multiple test output files (macrotest/bug_tuple_struct_shadowing.expanded.rs, macrotest/bug_unused_imports.expanded.rs, macrotest/wdf_device_create.expanded.rs, macrotest/wdf_device_create_device_interface.expanded.rs, macrotest/wdf_driver_create.expanded.rs, macrotest/wdf_request_retrieve_output_buffer.expanded.rs, macrotest/wdf_spin_lock_acquire.expanded.rs, macrotest/wdf_verifier_dbg_break_point.expanded.rs): Refactor the assertion for buffer size calculation from a negated if statement to a match statement for clearer error handling. [1] [2] [3] [4] [5] [6] [7] [8]

@wmmc88 wmmc88 marked this pull request as ready for review September 10, 2025 01:19
Copilot AI review requested due to automatic review settings September 10, 2025 01:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the CI workflow to use nightly Rust and refactors macro test output files to improve error handling patterns. The changes are driven by updates to the nightly Rust compiler which changed how macro expansion generates assertion code.

Key changes:

  • Updates CI workflow to install cargo-make and run additional top-level tests
  • Refactors assertion logic in multiple macro test output files from negated if statements to match expressions for clearer error handling
  • Fixes a symlink creation function to handle edge cases more robustly

Reviewed Changes

Copilot reviewed 11 out of 16 changed files in this pull request and generated no comments.

File Description
.github/workflows/test.yaml Adds cargo-make installation and new test job for top-level tests
tests/wdk-macros-tests/src/lib.rs Improves symlink creation logic and fixes formatting
tests/mixed-package-kmdf-workspace/crates/driver/Cargo.toml Disables tests due to GitHub runner issues
Multiple macrotest/*.expanded.rs files Updates generated macro expansion outputs to use match instead of negated if for assertions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@wmmc88 wmmc88 added this pull request to the merge queue Sep 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 11, 2025
@wmmc88 wmmc88 added this pull request to the merge queue Sep 11, 2025
Merged via the queue into microsoft:main with commit 1b4ea7a Sep 11, 2025
276 of 277 checks passed
@wmmc88 wmmc88 deleted the fix-nightly-ws-tests branch September 11, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants