Skip to content

Conversation

@wmmc88
Copy link
Collaborator

@wmmc88 wmmc88 commented Aug 11, 2025

fixes #454

@wmmc88 wmmc88 requested a review from Copilot August 11, 2025 18:58
@wmmc88
Copy link
Collaborator Author

wmmc88 commented Aug 11, 2025

blocking on #451

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances debug tracing capabilities in the bindgen and config modules of the WDK crate, addressing issue #454. The changes focus on improving observability during build processes and fixing configuration handling.

  • Adds comprehensive tracing instrumentation to configuration and bindgen functions
  • Fixes cargo metadata resolution to respect config.toml overrides by setting proper working directories
  • Includes test workspace improvements and minor corrections

Reviewed Changes

Copilot reviewed 22 out of 23 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
crates/wdk-build/src/lib.rs Adds tracing instrumentation to Config methods and fixes cargo metadata working directory
crates/wdk-build/src/bindgen.rs Adds tracing to bindgen functions and fixes metadata command working directory
crates/cargo-wdk/src/providers/exec.rs Adds working_dir parameter to CommandExec run method
crates/cargo-wdk/src/cli.rs Updates CommandExec run method calls to include working_dir parameter
crates/cargo-wdk/src/actions/build/build_task.rs Updates build task to use working directory for cargo commands
crates/cargo-wdk/src/actions/build/package_task.rs Updates package task command calls and fixes typo
crates/cargo-wdk/src/actions/new/mod.rs Updates command exec calls and fixes typo
crates/cargo-wdk/src/actions/build/tests.rs Updates test mocks to include working_dir parameter
tests/wdk-macros-tests/src/lib.rs Fixes spelling error in comment
tests/umdf-driver-workspace/Cargo.toml Simplifies workspace dependency declarations
tests/mixed-package-kmdf-workspace/Cargo.toml Simplifies workspace dependency declarations
tests/mixed-package-kmdf-workspace/crates/driver/Cargo.toml Disables tests for Windows Server 2022 compatibility
tests/customized-config-toml-workspace/ Adds new test workspace for config.toml patch testing
tests/Makefile.toml Adds new test workspace to cargo-make configuration
.github/workflows/test.yaml Adds cargo-make testing for top-level tests folder
.github/workflows/build.yaml Adds build and package steps for tests folder

Copilot AI review requested due to automatic review settings September 23, 2025 16:41
@wmmc88 wmmc88 force-pushed the increase-tracing-wdk-build branch from 2aef442 to 3f589ff Compare September 23, 2025 16:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@wmmc88 wmmc88 marked this pull request as ready for review September 23, 2025 16:47
@wmmc88 wmmc88 requested a review from a team September 24, 2025 17:46
Copy link
Contributor

@krishnakumar4a4 krishnakumar4a4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I will review this again. I clicked on submit review button assuming its different PR I am actively reviewing.

@wmmc88 wmmc88 added this pull request to the merge queue Sep 25, 2025
@wmmc88 wmmc88 removed this pull request from the merge queue due to a manual request Sep 25, 2025
@wmmc88 wmmc88 changed the title chore: enhance debug tracing in bindgen and config modules feat: enhance debug tracing in bindgen and config modules Sep 25, 2025
@wmmc88 wmmc88 added this pull request to the merge queue Sep 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 25, 2025
@wmmc88 wmmc88 added this pull request to the merge queue Sep 25, 2025
Merged via the queue into microsoft:main with commit 4877d12 Sep 25, 2025
389 of 405 checks passed
@wmmc88 wmmc88 deleted the increase-tracing-wdk-build branch September 25, 2025 17:47
@leon-xd leon-xd mentioned this pull request Oct 17, 2025
@wmmc88 wmmc88 mentioned this pull request Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand tracing instrumentation in wdk_build for lib.rs and bindgen.rs

3 participants