-
Notifications
You must be signed in to change notification settings - Fork 104
chore!: bump to Rust 2024 Edition #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
crates/cargo-wdk/tests/emulated-workspace/umdf-driver-workspace/crates/driver_1/src/lib.rs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the project to Rust 2024 Edition, requiring MSRV bump from 1.84 to 1.85. The key changes focus on wrapping unsafe operations that became required in the 2024 edition, particularly around export_name/no_mangle attributes and environment variable operations.
- Updated all
export_nameandno_mangleattributes to useunsafe()wrapper syntax - Added safe wrapper functions for
env::set_varandenv::remove_varoperations - Applied general formatting and clippy fixes throughout the codebase
Reviewed Changes
Copilot reviewed 47 out of 47 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Updated edition to "2024" and rust-version to "1.85.0" |
| Multiple test/example files | Added unsafe() wrapper to export_name attributes with safety comments |
| crates/wdk-build/src/utils.rs | Added safe wrapper functions set_var and remove_var for env operations |
| crates/wdk-sys/src/lib.rs | Added unsafe() wrapper to no_mangle attributes with safety comments |
| Various source files | Applied clippy fixes including import reordering and code simplifications |
crates/cargo-wdk/tests/emulated-workspace/umdf-driver-workspace/crates/driver_1/src/lib.rs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 91 out of 106 changed files in this pull request and generated 27 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
40f6ba7 to
3b43728
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 52 out of 52 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 69 out of 80 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Leon Durrenberger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 69 out of 80 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 53 out of 64 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Leon Durrenberger <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: Leon Durrenberger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 53 out of 64 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Leon Durrenberger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 53 out of 64 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@leon-xd quick question: why didn't our pipelines catch the wrong macrotest output files? Are we missing some coverage in this area?
Breaking change:
Other changes
unsafewrapper aroundenv::set_var,env::remove_varfunctions, andno_mangleandexport_nameattributesclippyon wdk crate -- this was not done in the past PRs as no automatic uncommenting of WDK configuration happens in pipelinefmt&clippyfixescargo-sortinstallation toCONTRIBUTING.md