Skip to content

Conversation

@leon-xd
Copy link
Contributor

@leon-xd leon-xd commented Aug 1, 2025

Breaking change:

  • MSRV bumped: 1.84 => 1.85

Other changes

  • unsafe wrapper around env::set_var, env::remove_var functions, and no_mangle and export_name attributes
  • Ran clippy on wdk crate -- this was not done in the past PRs as no automatic uncommenting of WDK configuration happens in pipeline
  • general fmt & clippy fixes
  • added cargo-sort installation to CONTRIBUTING.md

Copilot AI review requested due to automatic review settings August 1, 2025 00:43

This comment was marked as outdated.

@wmmc88 wmmc88 requested a review from Copilot August 5, 2025 22:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the project to Rust 2024 Edition, requiring MSRV bump from 1.84 to 1.85. The key changes focus on wrapping unsafe operations that became required in the 2024 edition, particularly around export_name/no_mangle attributes and environment variable operations.

  • Updated all export_name and no_mangle attributes to use unsafe() wrapper syntax
  • Added safe wrapper functions for env::set_var and env::remove_var operations
  • Applied general formatting and clippy fixes throughout the codebase

Reviewed Changes

Copilot reviewed 47 out of 47 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Cargo.toml Updated edition to "2024" and rust-version to "1.85.0"
Multiple test/example files Added unsafe() wrapper to export_name attributes with safety comments
crates/wdk-build/src/utils.rs Added safe wrapper functions set_var and remove_var for env operations
crates/wdk-sys/src/lib.rs Added unsafe() wrapper to no_mangle attributes with safety comments
Various source files Applied clippy fixes including import reordering and code simplifications

Copilot AI review requested due to automatic review settings September 29, 2025 23:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 91 out of 106 changed files in this pull request and generated 27 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@wmmc88 wmmc88 added the next-release-priority Issues and PRs that should be prioritized to be in the next crates.io release label Sep 30, 2025
Copilot AI review requested due to automatic review settings October 8, 2025 19:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 52 out of 52 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings October 14, 2025 22:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 69 out of 80 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Leon Durrenberger <[email protected]>
Copilot AI review requested due to automatic review settings October 14, 2025 22:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 69 out of 80 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

gurry
gurry previously approved these changes Oct 15, 2025
Copilot AI review requested due to automatic review settings October 15, 2025 23:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 53 out of 64 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Leon Durrenberger <[email protected]>
Copilot AI review requested due to automatic review settings October 15, 2025 23:04
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Leon Durrenberger <[email protected]>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 53 out of 64 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Leon Durrenberger <[email protected]>
Copilot AI review requested due to automatic review settings October 15, 2025 23:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 53 out of 64 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@gurry gurry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@leon-xd quick question: why didn't our pipelines catch the wrong macrotest output files? Are we missing some coverage in this area?

@leon-xd leon-xd added this pull request to the merge queue Oct 16, 2025
Merged via the queue into microsoft:main with commit de6622a Oct 16, 2025
229 checks passed
@leon-xd leon-xd deleted the update-rust-2024 branch October 16, 2025 07:09
@leon-xd leon-xd mentioned this pull request Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

next-release-priority Issues and PRs that should be prioritized to be in the next crates.io release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants