-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: configure WDK configuration via parsing Cargo manifest metadata #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Last round of changes for this PR fixed a logic bug that broke automatic skipping of the packaging task for non-binary(ie driver) wdk packages, added more tests for that specific situation, fixed various issues identified by pipelines(ie. formatting, clippy), and expanded coverage of the pipelines to include the workspace-level tests and examples folders. |
wmmc88
commented
Aug 8, 2024
wmmc88
commented
Aug 15, 2024
ayodejiige
previously approved these changes
Aug 23, 2024
ayodejiige
approved these changes
Aug 23, 2024
hamzamust
approved these changes
Aug 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Aug 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables configuring the WDK Metadata via
[metadata.wdk]
tags in Cargo manifests.As a consequence of that new feature, several other changes were required:
cfg
based off of certain WDK configuration parameters* A
wdf.c
file is compiled and linked in to provide the__declspec(selectany)
that are not generated by bindgenwdk-sys
's build.rs that is otherwise not possible to generate conditionally (ex. call_unsafe_wdf_function_binding definition that points toOUT_DIR
,WDFFUNCTIONS
symbol name that depends on configuration,WDF_FUNCTION_TABLE
definition whose size depends on configuration, etc.)generated_bindings
copy of bindingslinks
keys in cargo manifests is deprecatedcargo check
to obtain out dir (and replace with wdk_sys passing the outdir to the procmacro)resolves #82