Build perf: Make calls to bindgen run in parallel #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmmc88
previously approved these changes
May 17, 2024
There was a problem hiding this comment.
This pr speeds up the build by parallelizing the generation of the bindings in outdir and in the generated_bindings folder. The latter was only added since it was easier to get diffs between prs when there are bindgen changes. I have a pr that removes this duplicate generation (since that pr also introduces feature in #82 so it doesnt make sense to only look at the km bindings diff).
I have written a cargo make task that will generate these binding diffs, and will clean it up and pr in the near future
I am still good to merge this until that lands
This is a little silly with all the clones, but it works.
wmmc88
approved these changes
May 28, 2024
hamzamust
approved these changes
May 29, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling this repo (or projects that depend on it), a large portion of the build time is spent waiting for bindgen to finish constructing bindings to the WDK. This can severely slow down iterative development and builds.
This PR makes a simple change to how we call bindgen by calling each function wrapping a call to it in parallel. On my machine this provides a speedup of running "cargo make" in windows-drivers-rs of about 20% (~500 seconds run time to ~400 seconds).
I wouldn't be surprised if we can refactor the calls even more to see greater speedups, but this was just a quick late afternoon project to speed up work on other features.