Log the ClangSharpPInvokeGenerator path and ensure the script doesn't fail for missing tools #497
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were found while testing dotnet/ClangSharp#235.
In particular, it is useful to log the resolved path for
ClangSharpPInvokeGeneratorso it can be asserted to be the expected one (ClangSharp's CI test should override the global tool, for example).Likewise,
Select-Stringdoes not output astringby default, it outputs aMicrosoft.PowerShell.Commands.MatchInfo: https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.utility/select-string?view=powershell-7.1#outputs which does not have a Length property. It is expected that-Rawbe passed if you want astring.Additionally, if there is no match the result can be
$null, which needs to be checked before getting the length.