Skip to content

Conversation

@tannergooding
Copy link
Member

These were found while testing dotnet/ClangSharp#235.

In particular, it is useful to log the resolved path for ClangSharpPInvokeGenerator so it can be asserted to be the expected one (ClangSharp's CI test should override the global tool, for example).

Likewise, Select-String does not output a string by default, it outputs a Microsoft.PowerShell.Commands.MatchInfo: https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.utility/select-string?view=powershell-7.1#outputs which does not have a Length property. It is expected that -Raw be passed if you want a string.

Additionally, if there is no match the result can be $null, which needs to be checked before getting the length.

@tannergooding
Copy link
Member Author

CC. @sotteson1

@sotteson1
Copy link
Contributor

Thanks @tannergooding!

@sotteson1 sotteson1 merged commit 194c267 into microsoft:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants