Skip to content

Dispose XmlReader in XmlRunSettingsUtilities #5094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Dispose XmlReader in XmlRunSettingsUtilities #5094

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Microsoft.TestPlatform.ObjectModel/Utilities/XmlRunSettingsUtilities.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ public static bool IsInProcDataCollectionEnabled(string? runSettingsXml)
try
{
using var stringReader = new StringReader(runSettingsXml);
var reader = XmlReader.Create(stringReader, ReaderSettings);
using var reader = XmlReader.Create(stringReader, ReaderSettings);

// read to the fist child
XmlReaderUtilities.ReadToRootNode(reader);
Expand Down Expand Up @@ -277,7 +277,7 @@ public static bool IsInProcDataCollectionEnabled(string? runSettingsXml)

runSettingsXml = runSettingsXml.Trim();
using StringReader stringReader1 = new(runSettingsXml);
XmlReader reader = XmlReader.Create(stringReader1, ReaderSettings);
using XmlReader reader = XmlReader.Create(stringReader1, ReaderSettings);

// read to the fist child
XmlReaderUtilities.ReadToRootNode(reader);
Expand Down Expand Up @@ -357,7 +357,7 @@ internal static void ThrowOnNoAttributes(XmlReader reader)
try
{
using var stringReader = new StringReader(settingsXml);
XmlReader reader = XmlReader.Create(stringReader, ReaderSettings);
using XmlReader reader = XmlReader.Create(stringReader, ReaderSettings);

// read to the fist child
XmlReaderUtilities.ReadToRootNode(reader);
Expand Down