Skip to content

Added notification delay when there are no subscribers #4620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Added notification delay when there are no subscribers #4620

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe0496a
Added delay when there are no subscribers
cvpoienaru Jul 25, 2023
482d118
Added timeout constant
cvpoienaru Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Microsoft.TestPlatform.CommunicationUtilities/LengthPrefixCommunicationChannel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ namespace Microsoft.VisualStudio.TestPlatform.CommunicationUtilities;
/// </summary>
public class LengthPrefixCommunicationChannel : ICommunicationChannel
{

private const int NoSubscriberTimeoutMs = 100;

private readonly BinaryReader _reader;

private readonly BinaryWriter _writer;
Expand Down Expand Up @@ -87,6 +90,11 @@ public Task NotifyDataAvailable()
// connection is closed.
if (MessageReceived != null)
{
if (MessageReceived.GetInvocationList().Length == 0)
{
Task.Delay(NoSubscriberTimeoutMs);
}

var data = _reader.ReadString();
MessageReceived.SafeInvoke(this, new MessageReceivedEventArgs { Data = data }, "LengthPrefixCommunicationChannel: MessageReceived");
}
Expand Down