Skip to content

Fix potential trx logger NRE #4240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MarcoRossignoli merged 2 commits into from
Jan 3, 2023
Merged

Fix potential trx logger NRE #4240

MarcoRossignoli merged 2 commits into from
Jan 3, 2023

Conversation

@MarcoRossignoli
Copy link
Contributor

@MarcoRossignoli MarcoRossignoli commented Jan 3, 2023 •
edited
Loading

Fix potential trx logger NRE

Fixes #4224

Evangelink
Evangelink reviewed Jan 3, 2023
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add some test?

@MarcoRossignoli
Copy link
Contributor Author

MarcoRossignoli commented Jan 3, 2023

Could we add some test?

I was doing it

@MarcoRossignoli MarcoRossignoli changed the title Fix possible trx logger NRE Fix potential trx logger NRE Jan 3, 2023
@MarcoRossignoli MarcoRossignoli enabled auto-merge (squash) January 3, 2023 08:45
@MarcoRossignoli MarcoRossignoli merged commit 3df8944 into microsoft:main Jan 3, 2023
@MarcoRossignoli MarcoRossignoli deleted the fixtrxnre branch January 3, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Evangelink Evangelink Evangelink approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TrxLogger throws a NullReferenceException when using TrxLogger.Initialize(TestLoggerEvents, string)

2 participants

@MarcoRossignoli @Evangelink