Skip to content

Make TraitCollection serializable in all supported TFMs #3963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Evangelink merged 1 commit into from
Aug 24, 2022
Merged

Make TraitCollection serializable in all supported TFMs #3963

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/Microsoft.TestPlatform.ObjectModel/TraitCollection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ namespace Microsoft.VisualStudio.TestPlatform.ObjectModel;
/// <summary>
/// Class that holds collection of traits
/// </summary>
#if NETFRAMEWORK // REVIEW ME: This could be enabled for netcore and netstandard
[Serializable]
#endif
public class TraitCollection : IEnumerable<Trait>
{
internal const string TraitPropertyId = "TestObject.Traits";
Expand All @@ -27,9 +25,7 @@ public class TraitCollection : IEnumerable<Trait>
#pragma warning restore 618
typeof(TestObject));

#if NETFRAMEWORK // REVIEW ME: This could be enabled for netcore and netstandard
[NonSerialized]
#endif
private readonly TestObject _testObject;

internal TraitCollection(TestObject testObject)
Expand Down