Replace netstandard1.0 and netstandard1.3 with netstandard2.0 #3921
Conversation
Evangelink
requested review from
Haplois,
MarcoRossignoli and
nohwnd
as code owners
src/Microsoft.TestPlatform.AdapterUtilities/PublicAPI/PublicAPI.Shipped.txt
Show resolved
Hide resolved
| /// Class that holds collection of traits | ||
| /// </summary> | ||
| #if NETFRAMEWORK | ||
| #if NETFRAMEWORK // REVIEW ME: This could be enabled for netcore and netstandard |
There was a problem hiding this comment.
Not for this PR but is there any reason not to enable this for all tfms? The ones we have all support it.
| branch="$BranchName$" | ||
| commit="$CommitId$" /> | ||
| <dependencies> | ||
| <group targetFramework="uap10.0"> |
There was a problem hiding this comment.
Shall we add netstandard2.0 in replacement of uap10.0?
There was a problem hiding this comment.
don't we have netstandard2.0 in the layout?
There was a problem hiding this comment.
I have just checked and we have only net462, netcoreapp3.1 and before uap10.0. That's why I think adding netstandard2.0 would be useful.
| <dependency id="System.Security.Principal.Windows" version="[4.0.1, )" /> | ||
| <dependency id="System.Collections.Specialized" version="[4.0.1, )" /> | ||
| <group targetFramework="netstandard2.0"> | ||
| <!-- REVIEW ME: Why don't we have dependency to Newtonsoft.Json here? --> |
There was a problem hiding this comment.
Other TFMs are declaring dependency on Newtonsoft.Json. Why are we not doing it for netstandard2.0?
There was a problem hiding this comment.
I will fix this one as a follow-up PR so things don't get mixed up.
| <dependency id="Newtonsoft.Json" version="$JsonNetVersion$"/> | ||
| </group> | ||
|
|
||
| <group targetFramework="uap10.0"> |
There was a problem hiding this comment.
I don't think it makes sense to have netstandard2.0 for testhost but then I am not sure what to ship for uap?
There was a problem hiding this comment.
Why it does not make sense to have netstandard2.0 for testhost?
There was a problem hiding this comment.
As we don't target netcoreapp, I thought this package is meant for specific scenario and so netstandard2.0 seemed too generic.
|
@nohwnd there's UWP discussion open I think, what to ship in the nuget. |
nohwnd
left a comment
nohwnd
left a comment
There was a problem hiding this comment.
Withdrawing my approval, so we can finish the uwp discussion.
There was a problem hiding this comment.
IMO, we should keep netstandard1.3 too.
If we change our baseline to netstandard2.0 we will lose UAP support for Windows 10 before RS3 (1709), the issue here is Windows 10 RS1 LTSC is supported until October 2026, and Windows 10 TH1 LTSC is supported until October 2025.
Said versions are already retired in general access branches, so I am OK either way.
So vote
- 👍 for removal of
netstandard1.3too. - 👎 for keeping
netstandard1.3, and removingnetstandard1.0only.
|
For the record, the problem wouldn't be on TP side as it's not injected onto UWP but problem will happen for Test Frameworks. For example, we won't be able to ship new versions of MSTest still supporting these old versions of UWP as we will no longer have the correct netstandard for ObjectModel and related objects. @Haplois to correct me if I misunderstood your concern. |
what does it mean?Can you elaborate? |
They are already retired in consumer and enterprise editions, only supported channel is LTSC. |
|
We discussed the issue in a team meeting and decided to move forward with this change. @Haplois @MarcoRossignoli @nohwnd I'd like to have 3 approvals on this one if you have some time. |
4 participants
Description
Target .netstandard2.0 instead of netstandard1.0/netstandard1.3
Related issue
Fixes AB#1585589