Skip to content

Conversation

@MarcoRossignoli
Copy link
Contributor

Looks like we already moved away from msdia managed wrapper in favor of pinvoke to msdia140.dll https://github.com/microsoft/vstest/pull/1018/files#diff-1ce965d15e48a18ef21ff22c84fd034f046ddc15aebea432babfa403cff86473
Remove ref to Microsoft.Internal.Dia.Interop that contains msdia140typelib_clr0200.dll
image

@MarcoRossignoli MarcoRossignoli marked this pull request as draft June 28, 2022 17:01
@Evangelink
Copy link
Member

Changes looks good, are we waiting for something to merge it?

@MarcoRossignoli
Copy link
Contributor Author

yeah...I'm doing some manual tests

@MarcoRossignoli MarcoRossignoli marked this pull request as ready for review June 29, 2022 14:26
@MarcoRossignoli MarcoRossignoli enabled auto-merge (squash) June 29, 2022 14:27
@MarcoRossignoli MarcoRossignoli merged commit 582a8cb into microsoft:main Jun 29, 2022
@MarcoRossignoli MarcoRossignoli deleted the removoldmsdia branch June 29, 2022 14:27
akoeplinger added a commit to dotnet/sdk that referenced this pull request Mar 7, 2024
akoeplinger added a commit to dotnet/sdk that referenced this pull request Mar 8, 2024
…ets (#39304)

The msdia140typelib_clr0200.dll was removed from vstest in microsoft/vstest#3822

This actually never worked in the Microsoft build (because we're building the SDK layout on Windows) and we shipped the binary in the non-Windows SDKs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants