Fixed telemetry data sharing exception #3676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 24, 2022 16:58
Evangelink
reviewed
May 25, 2022
Member
Evangelink
left a comment
Evangelink
left a comment
There was a problem hiding this comment.
Do we have any test ensuring we won't regress on the cleaning of the metrics in both Initialize methods?
src/Microsoft.TestPlatform.CrossPlatEngine/Execution/ExecutionManager.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.CrossPlatEngine/PublicAPI/PublicAPI.Shipped.txt
Show resolved
Hide resolved
src/Microsoft.TestPlatform.CrossPlatEngine/PublicAPI/PublicAPI.Shipped.txt
Show resolved
Hide resolved
Member
Author
Sorry, missed this comment. We don't have any such tests yet but I am working on adding them. |
nohwnd
reviewed
May 26, 2022
src/Microsoft.TestPlatform.CrossPlatEngine/TestSession/TestSessionPool.cs
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
May 26, 2022
src/Microsoft.TestPlatform.CrossPlatEngine/Execution/ExecutionManager.cs
Show resolved
Hide resolved
nohwnd
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.