Test matrix #3459
Test matrix #3459
Conversation
Use net48 for acceptance
This reverts commit 543c21c.
Co-authored-by: Amaury Levé <[email protected]>
Co-authored-by: Amaury Levé <[email protected]>
… it is used with multiple different meanings
| // Do not generate the data rows here, properties (e.g. DebugVSTestConsole) are not populated until after constructor is done. | ||
| } | ||
|
|
||
| public bool DebugVSTestConsole { get; set; } |
There was a problem hiding this comment.
Not sure if this will bring much but I see this set of properties appears in multiple data sources, is it worth having an intermediate type? If we don't foresee much change going forward I don't mind the "copy/paste" state.
There was a problem hiding this comment.
How would that work?
Keep in mind that these are properties on attribute types, and they need to be from the set of valid attribute types. Bool is valid, but custom object is not because it is not a constant.
There was a problem hiding this comment.
I was thinking about inheritance and not composition here.
public abstract class TestDataSourceBase : TestDataSource<RunnerInfo>
{
public bool DebugVSTestConsole { get; set; }
public bool DebugTestHost { get; set; }
public bool DebugDataCollector { get; set; }
public bool NoDefaultBreakpoints { get; set; } = true;
}
public class MSTestCompatibilityDataSource : TestDataSourceBase
{
...
}But you are right that we would need to do something similar for attribute so that's not ideal.
Evangelink
left a comment
Evangelink
left a comment
There was a problem hiding this comment.
There are a couple of classes where you replaced some calls to the base TempDirectory for a local one. Is it on purpose or was it just for test and this needs to be reverted?
|
I looked at the PR and I could not find which classes are they? Can you give me an example? |
|
They are all in |
|
Reverted that back to use TempDirectory from the base class. |
|
This was blocking on the DiscoveryCancellation test, that I stabilized, but broke by the threshold. I am fixing that in #3529 |
2 participants
Description
Run acceptance tests against multiple versions of our components.