Remove regions #3366
Merged
Remove regions #3366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoRossignoli
approved these changes
Feb 15, 2022
Member
|
@MarcoRossignoli @Evangelink I was just going to say that the regions in tests actually add value, and we should keep them before we replace them with something else. Please revert. Apart from that I found 1 place where I would like to add a comment, commented on that place above. |
Member
Author
|
@nohwnd Want me to revert all or just test part? |
Contributor
|
+1 @nohwnd about regions in tests. Also,
|
Member
|
For me all changes in tests, and for medeni the ones that hold interfaces. |
Evangelink
added a commit
to Evangelink/vstest
that referenced
this pull request
Feb 15, 2022
This reverts commit 128056e.
Evangelink
added a commit
that referenced
this pull request
Feb 15, 2022
Co-authored-by: Amaury Levé <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per comment on another PR, I am opening this PR to remove all regions in the code.