Log callbacks to delegates better #3283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
reviewed
Jan 27, 2022
| /// <inheritdoc /> | ||
| public Task NotifyDataAvailable() | ||
| { | ||
| // TODO: Review the comment below, because it says something different than what is |
Member
There was a problem hiding this comment.
Is it a todo for you before the PR gets merged or a later change that needs to be done? If the 2nd, could we create a ticket and link it to the todo?
src/Microsoft.TestPlatform.CommunicationUtilities/SocketCommunicationManager.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.CommunicationUtilities/SocketCommunicationManager.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.CommunicationUtilities/SocketCommunicationManager.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.CoreUtilities/Utilities/MulticastDelegateUtilities.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.CoreUtilities/Utilities/MulticastDelegateUtilities.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.CoreUtilities/Utilities/MulticastDelegateUtilities.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.CoreUtilities/Utilities/MulticastDelegateUtilities.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.CoreUtilities/Utilities/MulticastDelegateUtilities.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.CommunicationUtilities/LengthPrefixCommunicationChannel.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.CoreUtilities/Utilities/MulticastDelegateUtilities.cs
Outdated
Show resolved
Hide resolved
Contributor
|
I think it's a good addition thx @nohwnd, it should help a lot during the investigations. |
nohwnd
commented
Jan 28, 2022
src/Microsoft.TestPlatform.CoreUtilities/Utilities/MulticastDelegateUtilities.cs
Outdated
Show resolved
Hide resolved
nohwnd
commented
Jan 28, 2022
src/Microsoft.TestPlatform.CoreUtilities/Utilities/MulticastDelegateUtilities.cs
Outdated
Show resolved
Hide resolved
nohwnd
commented
Jan 28, 2022
src/Microsoft.TestPlatform.CoreUtilities/Utilities/MulticastDelegateUtilities.cs
Outdated
Show resolved
Hide resolved
nohwnd
commented
Jan 28, 2022
src/Microsoft.TestPlatform.CoreUtilities/Utilities/MulticastDelegateUtilities.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Amaury Levé <[email protected]>
Evangelink
approved these changes
Jan 28, 2022
Member
Evangelink
left a comment
Evangelink
left a comment
There was a problem hiding this comment.
A few minor comments, otherwise LGTM.
test/Microsoft.TestPlatform.Client.UnitTests/Execution/TestRunRequestTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.Common/DataCollection/DataCollectionAttachmentManager.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.CommunicationUtilities/SocketCommunicationManager.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.CommunicationUtilities/SocketCommunicationManager.cs
Outdated
Show resolved
Hide resolved
nohwnd
commented
Jan 28, 2022
src/Microsoft.TestPlatform.Common/DataCollection/DataCollectionAttachmentManager.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Amaury Levé <[email protected]>
auto-merge was automatically disabled
January 28, 2022 14:26
Pull Request is not mergeable
Evangelink
approved these changes
Feb 2, 2022
MarcoRossignoli
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Log what is being called when event is invoked.
Example of the log: TpTrace Verbose: 0 : 20708, 3, 2022/01/27, 13:26:24.691, 2456941827563, vstest.console.exe, MulticastDelegateUtilities.SafeInvoke: InternalTestLoggerEvents.SendTestRunStart: Invoking callback 1/1 for Microsoft.VisualStudio.TestPlatform.CommandLine.Internal.ConsoleLogger.TestRunStartHandler, took 0 ms.
TpTrace Verbose: 0 : 84508, 7, 2022/01/27, 13:33:05.983, 2460954751207, vstest.console.exe, MulticastDelegateUtilities.SafeInvoke: TestRun.TestRunComplete: Invoking callback 2/2 for Microsoft.VisualStudio.TestPlatform.CommandLine.TestRunResultAggregator.TestRunCompletionHandler, took 0 ms.
TpTrace Verbose: 0 : 84508, 7, 2022/01/27, 13:33:05.983, 2460954753814, vstest.console.exe, MulticastDelegateUtilities.SafeInvoke: TestRun.TestRunComplete: Invoking callback 2/2 for Microsoft.VisualStudio.TestPlatform.CommandLine.Processors.RunTestsArgumentExecutor+TestRunRequestEventsRegistrar.TestRunRequest_OnRunCompletion, took 0 ms.
TpTrace Verbose: 0 : 62012, 5, 2022/01/27, 13:46:07.014, 2468765066033, vstest.console.exe, TcpClientExtensions.MessageLoopAsync: Polling on remoteEndPoint: 127.0.0.1:1055 localEndPoint: 127.0.0.1:1054
TpTrace Verbose: 0 : 62012, 5, 2022/01/27, 13:46:07.014, 2468765066212, vstest.console.exe, TcpClientExtensions.MessageLoopAsync: NotifyDataAvailable remoteEndPoint: 127.0.0.1:1055 localEndPoint: 127.0.0.1:1054
TpTrace Verbose: 0 : 62012, 5, 2022/01/27, 13:46:07.014, 2468765066380, vstest.console.exe, LengthPrefixCommunicationChannel.NotifyDataAvailable: New data are waiting to be received, but there is no subscriber to be notified. Not reading them from the stream.