Fixing .net framework parallel issue #3192
Conversation
| this.RemoveManager(proxyDiscoveryManager); | ||
| this.RemoveManager(proxyDiscoveryManager); | ||
|
|
||
| proxyDiscoveryManager = this.CreateNewConcurrentManager(); |
There was a problem hiding this comment.
We should probably take advantage of the fact that .net fw testhost is shared and re-use it instead of killing it in the parallel discovery/execution case.
E.g.: parallelLevel = 4, .net fw test assmeblies = 8.
What happens now is that we spawn 4 testhosts, discover 4 .net fw test assmeblies, kill the 4 testhosts and then spawn another 4 testhosts to do the same for the remaining 4 test assemblies.
There was a problem hiding this comment.
Actually, after discovery 4 test assemblies, it will spawn next 4 testhosts one by one, not simultaniously as the first time.
So it will spawn 4 testhosts and when some testhost finishes discovering it will start new one for the next source.
As we discussed, I just created new issue for that idea : #3193.
Feel free to add or edit description for the issue.
Description
We already changed behaviour and now .net framework can also run in parallel and can have separate testhosts for each assembly.
And we faced issue when
ProxyDiscoveryManagerinstance was already closed before sending some request to testhost.So I removed that condition and now
ProxyDiscoveryManagerinstance will assign new object as it was previously only for .netcore.IsAborted condition is already not mandatory, because we need to execute that part of code any time we come here.
Related issue
Kindly link any related issues. E.g. Fixes #xyz.