CPP runner under .NET (Core) #3003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve testhost also from vstest.console folder when we cannot find it based on runtime config, or next to the test dll. This allows .net core projects that don't depend on test.sdk to run, as well as non-executable projects, and possibly native dlls - CPP runner
Haplois
reviewed
Aug 5, 2021
Contributor
Haplois
left a comment
Haplois
left a comment
There was a problem hiding this comment.
Under temp/testhost-core folder there are binaries, was that intentional?
Member
Author
|
yes it was intentional. Now I replaced them with a set of dlls that will come from nuget as soon as we get one. There are also few runtimeconfig files in temp/testhost now that I am not sure where to put in the final package. |
src/Microsoft.TestPlatform.TestHostProvider/Hosting/DotnetTestHostManager.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.TestHostProvider/Hosting/DotnetTestHostManager.cs
Outdated
Show resolved
Hide resolved
…HostManager.cs Co-authored-by: Marco Rossignoli <[email protected]>
…HostManager.cs Co-authored-by: Marco Rossignoli <[email protected]>
MarcoRossignoli
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add a meaningful description for this change.
Ensure the PR has required unit tests.
Related issue
Kindly link any related issues. E.g. Fixes #xyz.