Skip to content

Fix divide by zero in HTML logger #2723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
4 commits merged into from
Feb 1, 2021
Merged

Fix divide by zero in HTML logger #2723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b72e1b
Fix divide by zero in HTML logger
nohwnd Feb 1, 2021
3d33960
Address PR feedback
nohwnd Feb 1, 2021
be07219
Update src/Microsoft.TestPlatform.Extensions.HtmlLogger/HtmlLogger.cs
nohwnd Feb 1, 2021
117ee66
Fix comma
nohwnd Feb 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Microsoft.TestPlatform.Extensions.HtmlLogger/HtmlLogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ public void TestRunCompleteHandler(object sender, TestRunCompleteEventArgs e)
PassedTests = PassedTests,
TotalTests = TotalTests,
SkippedTests = SkippedTests,
PassPercentage = (PassedTests * 100) / TotalTests,
PassPercentage = TotalTests == 0 ? 0 : PassedTests * 100 / TotalTests,
TotalRunTime = GetFormattedDurationString(e.ElapsedTimeInRunningTests),
};
if (this.parametersDictionary.TryGetValue(HtmlLoggerConstants.LogFilePrefixKey, out string logFilePrefixValue) && !string.IsNullOrWhiteSpace(logFilePrefixValue))
Expand Down Expand Up @@ -441,4 +441,4 @@ internal string GetFormattedDurationString(TimeSpan duration)
return time.Count == 0 ? "< 1ms" : string.Join(" ", time);
}
}
}
}
14 changes: 14 additions & 0 deletions test/Microsoft.TestPlatform.Extensions.HtmlLogger.UnitTests/HtmlLoggerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,6 +573,20 @@ public void TestCompleteHandlerShouldWriteToXmlSerializerCorrectly()
Assert.IsTrue(htmlLogger.HtmlFilePath.Contains(".html"));
}

[TestMethod]
public void TestCompleteHandlerShouldNotDivideByZeroWhenThereAre0TestResults()
{

this.mockFileHelper.Setup(x => x.GetStream(It.IsAny<string>(), FileMode.Create, FileAccess.ReadWrite)).Callback<string, FileMode, FileAccess>((x, y, z) =>
{
}).Returns(new Mock<Stream>().Object);

this.htmlLogger.TestRunCompleteHandler(new object(), new TestRunCompleteEventArgs(null, false, true, null, null, TimeSpan.Zero));

Assert.AreEqual(0, this.htmlLogger.TestRunDetails.Summary.TotalTests);
Assert.AreEqual(0, this.htmlLogger.TestRunDetails.Summary.PassPercentage);
}

private static TestCase CreateTestCase(string testCaseName)
{
return new TestCase(testCaseName, new Uri("some://uri"), "DummySourceFileName");
Expand Down