Skip to content

Conversation

@nohwnd
Copy link
Member

@nohwnd nohwnd commented Nov 4, 2020

Description

Build on linux using build.sh.

</ProjectReference>
</ItemGroup>
<ItemGroup>
<ItemGroup Condition=" '$(OS)' == 'Windows_NT' OR '$(TargetFramework)' != 'net451' ">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is bleh, but when I just enable it it succeeds on windows but not on linux, when I make it conditional to just NOT net451 it fails on windows. And without the ref it fails on Linux...

Copy link
Contributor

@Haplois Haplois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nohwnd nohwnd merged commit fa9acdb into microsoft:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants