Changed new configurator method name #2397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhitejJohn
approved these changes
Apr 13, 2020
Contributor
|
@vritant24 : Please create a cherry-pick to master as well. |
nohwnd
approved these changes
Apr 13, 2020
AbhitejJohn
reviewed
Apr 14, 2020
AbhitejJohn
reviewed
Apr 14, 2020
vritant24
added a commit
that referenced
this pull request
Apr 14, 2020
* Changed new configurator method name * added more robust heck for target framework * default to FrameWork40 * fixed comment typo
nohwnd
pushed a commit
that referenced
this pull request
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old method name caused an ambiguous match exception since there is code in places we are still discovering that call the fakes configuration method with the name alone, not accounting for overloads.
Some more changes to variable names to explicitly show the difference