Trx changes for fqdn mapping in test method name #2259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhsarab
reviewed
Dec 2, 2019
| Debug.Assert(!string.IsNullOrEmpty(name), "name is null"); | ||
| Debug.Assert(!string.IsNullOrEmpty(className), "className is null"); | ||
| this.name = name; | ||
| this.name = name.StartsWith(className) ? name.Remove(0, $"{className}.".Length) : name; |
Contributor
There was a problem hiding this comment.
Should we do this in the Converter itself ?
singhsarab
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing data driven xunit method name.
The execution id and the test Id is linking attributes between the 2 nodes. The result node will remain as is and it today contains the display name for the result which translates to test run title in the pipeline.
In the Unit Test definition node the method name of xunit test is "XUnitTestProject.UnitTest1.Test1(a: 1)" which technically speaking is not correct. It has to be "XUnitTestProject.UnitTest1.Test1" and we are not losing any data this way as the result display name still remains the same.
This fix is taken as part of running the data driven xunit tests in pipeline