Implemented the cancellation of discovery request #2076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhsarab
reviewed
Jun 27, 2019
Contributor
|
@cltshivash : Would be great to have this in whenever you think its ready. |
singhsarab
reviewed
Jul 9, 2019
test/Microsoft.TestPlatform.AcceptanceTests/TranslationLayerTests/DiscoverTests.cs
Show resolved
Hide resolved
singhsarab
approved these changes
Jul 9, 2019
Contributor
singhsarab
left a comment
singhsarab
left a comment
There was a problem hiding this comment.
Approving with suggestion
Contributor
|
@singhsarab , @cltshivash : Wondering if we could update the test platform insertion on the VS side to include this change. |
Contributor
Author
|
Addresses issue #149 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented the changes to cancel a discovery request through the design mode client