VSTest targeting netstandard 2.0 - #2067
Conversation
| <TargetFrameworks>netstandard1.4;net451</TargetFrameworks> | ||
| <TargetFrameworks Condition=" '$(DotNetBuildFromSource)' == 'true' ">netstandard1.4</TargetFrameworks> | ||
| <TargetFrameworks>netstandard2.0;net451</TargetFrameworks> | ||
| <TargetFrameworks Condition=" '$(DotNetBuildFromSource)' == 'true' ">netstandard2.0</TargetFrameworks> |
There was a problem hiding this comment.
can this move into the TestPlatform.settings.targets ? Will prevent adding for every project
| </PackageReference> | ||
| <PackageReference Include="System.Reflection.TypeExtensions"> | ||
| <Version>4.1.0</Version> | ||
| <Version>1.6.0</Version> |
There was a problem hiding this comment.
1.6.0 [](start = 15, length = 5)
Do we bump up this version or remain at 1.3.0?
There was a problem hiding this comment.
There was a problem hiding this comment.
Sarabjot Singh (@singhsarab) Seems normal when opened in VS. |
Vagisha Nidhi (vagisha-nidhi)
changed the title
| throw new ArgumentException("Illegal characters in path."); | ||
| } | ||
|
|
||
| var di = new FileInfo(argument); |
There was a problem hiding this comment.
FileInfo [](start = 29, length = 8)
Keep it DirectoryInfo
Sarabjot Singh (singhsarab)
left a comment
Sarabjot Singh (singhsarab)
left a comment
There was a problem hiding this comment.
Approving with suggestions.
Please do make sure you have made all the changes requested. Removed netstandard1.4 references from test assets as well.
It will become increasingly difficult to maintain since the tests can no longer target netcoreapp1.1 since microsoft/vstest#2067
|
This is super unfortunate. We have projects targeting netstandard1.x (test running on netcoreapp1.1), and this change means we can never update Microsoft.NET.Test.Sdk to any version newer than 16.1.1. |
Support for netcoreapp1.1 was removed in microsoft/vstest#2067 and microsoft/vstest#2192, so we can no longer take updates to this package.
[master] Update dependencies from dotnet/arcade - Updates: - Microsoft.DotNet.Arcade.Sdk: from 5.0.0-beta.20117.3 to 5.0.0-beta.20374.1 - Upadte xcopy-msbuild - Switch to Arcade UnitTest targets and props - Install the 3.1.0 runtime for test running - Use default test versions from Arcade - Work around implicit package reference warning - Set DOTNET_ROOT variable - Remove not working workaround for implicit package reference - Reference the XUnit Assert package - Lock to prior version of Microsoft.NET.Test.Sdk Support for netcoreapp1.1 was removed in microsoft/vstest#2067 and microsoft/vstest#2192, so we can no longer take updates to this package.
|
Sam Harwell (@sharwell) Is it not possible to update to netcoreapp2.1, or any of the supported .NET Core versions? |
|
Jakub Jareš (@nohwnd) We use netcoreapp2.1 for testing our netstandard2.0 build. netcoreapp1.1 is a better representation of our intended support scenario. |
|
I am afraid we can't help you there 🙁 I suspect downgrading testhost to netcoreapp1.1 would be a significant effort. /cc Pavel Horak (@pavelhorak) |
[master] Update dependencies from dotnet/arcade - Updates: - Microsoft.DotNet.Arcade.Sdk: from 5.0.0-beta.20117.3 to 5.0.0-beta.20374.1 - Upadte xcopy-msbuild - Switch to Arcade UnitTest targets and props - Install the 3.1.0 runtime for test running - Use default test versions from Arcade - Work around implicit package reference warning - Set DOTNET_ROOT variable - Remove not working workaround for implicit package reference - Reference the XUnit Assert package - Lock to prior version of Microsoft.NET.Test.Sdk Support for netcoreapp1.1 was removed in microsoft/vstest#2067 and microsoft/vstest#2192, so we can no longer take updates to this package.
5 participants
Related issue: #2073