Skip to content

Conversation

@ViktorHofer
Copy link
Member

Description

No package exists for System.Runtime.InteropServices.RuntimeInformation with version 4.1.0. Downgrading the version to fix the nuget restore error.

Related issue

C:\git\corefx\src\System.Windows.Extensions\tests\System.Windows.Extensions.Tests.csproj : error NU1603: Microsoft.TestPlatform.ObjectModel 16.1.1 depends on System.Runtime.InteropServices.RuntimeInformation (>= 4.1.0) but System.Runtime.InteropServices.RuntimeInformation 4.1.0 was not found. An approximate best match of System.Runtime.InteropServices.RuntimeInformation 4.3.0 was resolved. [C:\git\corefx\src\tests.proj]

@ViktorHofer
Copy link
Member Author

@singhsarab PTAL

@ViktorHofer
Copy link
Member Author

@singhsarab this should be a release blocker as during conflict resolution nuget will always complain when having a .NET Framework configuration in the project. Can you please publish a new package with the change?

@ViktorHofer
Copy link
Member Author

cc @mayankbansal018

@mayankbansal018
Copy link
Contributor

@ViktorHofer I would check how was this getting resolved earlier for us, or were we also just ignoring the error. From the changes it doesn't look anything is impacted, will try to merge this on Monday.

@ViktorHofer
Copy link
Member Author

gentle ping

@mayankbansal018
Copy link
Contributor

@ViktorHofer this was already fixed via PR #2055.
We seemed to have gotten this bug from multiple location, & somehow the other PR got checked in. We will try to be more careful from going forward.

Closing this.

/cc @singhsarab , @ShreyasRmsft , @cltshivash

@ViktorHofer ViktorHofer deleted the patch-1 branch June 17, 2019 15:02
@ViktorHofer
Copy link
Member Author

No problem at all. Happy to see this fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants