Data collector extensibility in Test Plugin Cache #1991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cltshivash
reviewed
Apr 17, 2019
src/Microsoft.TestPlatform.CrossPlatEngine/Client/ProxyExecutionManager.cs
Show resolved
Hide resolved
Contributor
not related to your PR, but please fix this (private..?) Refers to: src/Microsoft.TestPlatform.CrossPlatEngine/DataCollection/InProcDataCollectionExtensionManager.cs:27 in 215b527. [](commit_id = 215b527, deletion_comment = False) |
cltshivash
reviewed
Apr 17, 2019
...icrosoft.TestPlatform.CrossPlatEngine/DataCollection/InProcDataCollectionExtensionManager.cs
Outdated
Show resolved
Hide resolved
cltshivash
reviewed
Apr 17, 2019
| private string GetCodebase(string codeBase) | ||
| { | ||
| return Path.IsPathRooted(codeBase) ? codeBase : Path.Combine(this.defaultCodeBase, codeBase); | ||
| if (!Path.IsPathRooted(codeBase)) |
Contributor
There was a problem hiding this comment.
suggestion: you can flip the condition. if (path.ispathrooted(,....)) { return codebase }
cltshivash
reviewed
Apr 17, 2019
...atform.CrossPlatEngine.UnitTests/DataCollection/InProcDataCollectionExtensionManagerTests.cs
Outdated
Show resolved
Hide resolved
...icrosoft.TestPlatform.CrossPlatEngine/DataCollection/InProcDataCollectionExtensionManager.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description